Date: Fri, 9 Oct 2009 12:09:55 -0700
From: Greg KH <greg@kroah.com>
To: Johan Hovold <jhovold@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-usb@vger.kernel.org,
       e9hack <e9hack@googlemail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: Fix read regression in 2.6.31.
Message-ID: <20091009190955.GA958@kroah.com>
References: <Pine.LNX.4.44L0.0909191217430.15223-100000@netrider.rowland.org>
 <20090920201836.GA5602@localhost>
 <20091009175602.GC5718@kroah.com>
 <20091009184113.GE21054@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091009184113.GE21054@localhost>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1510
Lines: 38

On Fri, Oct 09, 2009 at 08:41:13PM +0200, Johan Hovold wrote:
> On Fri, Oct 09, 2009 at 10:56:02AM -0700, Greg KH wrote:
> > On Sun, Sep 20, 2009 at 10:18:36PM +0200, Johan Hovold wrote:
> > > Use ASYNCB_INITIALIZED to determine when to stop reading.
> > > 
> > > Port count can no longer be used to determine when to stop reading from
> > > the device as it can be zero when the first read callbacks are made (see
> > > tty_port_block_til_read where port count is temporarily decremented
> > > during serial_open).
> > > 
> > > Signed-off-by: Johan Hovold <jhovold@gmail.com>
> > > ---
> > > 
> > > Hi, 
> > > 
> > > Here's a patch which fixes the port count issue for all drivers. I only
> > > have access to an ftdi device at the moment so that's the only driver
> > > I've been able to test (against latest git with latest patches from
> > > Greg's tree). 
> > 
> > Hm, this doesn't apply on top of the other ftdi patches.  Could you
> > respin this?
> 
> There were some issues with that patch, so please disregard that one.
> Sorry. There are probably still some problems with some of the other
> drivers (at least theoretical ones) due to the tty changes that broke
> ftdi, but there is currently no patch to fix them all.

Ok, dropped :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/