Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761544AbZJIXQq (ORCPT ); Fri, 9 Oct 2009 19:16:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759045AbZJIXQq (ORCPT ); Fri, 9 Oct 2009 19:16:46 -0400 Received: from kroah.org ([198.145.64.141]:36722 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758959AbZJIXQp (ORCPT ); Fri, 9 Oct 2009 19:16:45 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Fri Oct 9 16:10:00 2009 Message-Id: <20091009231000.229589417@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Fri, 09 Oct 2009 16:08:37 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Samuel Thibault , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "David S. Miller" , Andi Kleen Subject: [patch 01/26] x86: fix csum_ipv6_magic asm memory clobber References: <20091009230836.316410305@mini.kroah.org> Content-Disposition: inline; filename=x86-fix-csum_ipv6_magic-asm-memory-clobber.patch In-Reply-To: <20091009231249.GA31084@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 38 2.6.31-stable review patch. If anyone has any objections, please let us know. ------------------ From: Samuel Thibault commit 392d814daf460a9564d29b2cebc51e1ea34e0504 upstream. Just like ip_fast_csum, the assembly snippet in csum_ipv6_magic needs a memory clobber, as it is only passed the address of the buffer, not a memory reference to the buffer itself. This caused failures in Hurd's pfinetv4 when we tried to compile it with gcc-4.3 (bogus checksums). Signed-off-by: Samuel Thibault Cc: Ingo Molnar Cc: Thomas Gleixner Cc: "H. Peter Anvin" Acked-by: "David S. Miller" Cc: Andi Kleen Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/checksum_32.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/x86/include/asm/checksum_32.h +++ b/arch/x86/include/asm/checksum_32.h @@ -161,7 +161,8 @@ static inline __sum16 csum_ipv6_magic(co "adcl $0, %0 ;\n" : "=&r" (sum) : "r" (saddr), "r" (daddr), - "r" (htonl(len)), "r" (htonl(proto)), "0" (sum)); + "r" (htonl(len)), "r" (htonl(proto)), "0" (sum) + : "memory"); return csum_fold(sum); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/