DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        b=kgJwkJl9wvuwMDLey1ckikTgWi5LEZHXyPMPCArYto9qvc9a+4BrZ/AFcwJ7rL5X2a
         pijYHsKzo7ORsKFL0Uq8+C2QjOhwnqnrVPoGY0Jl15piptFX+LLUfvHbEPk27Ws0fowc
         iowEFef02/5Dw3u5p2qbAW3/DBR8uBAp3qBeQ=
MIME-Version: 1.0
In-Reply-To: <20091010085732.GA10923@feather>
References: <20091010085732.GA10923@feather>
Date: Sat, 10 Oct 2009 03:33:20 -0700
Message-ID: <70318cbf0910100333m128e3500vb1659a55a9f49768@mail.gmail.com>
Subject: Re: [PATCH] New attribute designated_init: mark a struct as requiring 
	designated init
From: Christopher Li <sparse@chrisli.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1935
Lines: 39

On Sat, Oct 10, 2009 at 1:58 AM, Josh Triplett <josh@joshtriplett.org> wrote:
> Some structure types provide a set of fields of which most users will
> only initialize the subset they care about. ?Users of these types should
> always use designated initializers, to avoid relying on the specific
> structure layout. ?Examples of this type of structure include the many

The patch is very well written with nice documentations and test case.
It applies and runs fine.

I am curious weather this is some thing the kernel developers want to
use. Please speak up if you want to annotate the kernel structure to
issue such warning. If some one use it, I have no problem adding it to
sparse.

I am not sure how useful this is yet.  If the structure is changed, most
likely the positional initialization will fail due to type mismatching.
Some real life example how this feature can expose some otherwise
hard to detect bug would be nice.

With this approach, we need to annotate the kernel to benefit from it.
Another idea is that we can find out how different part of the kernel
initialize the same structure. If most of them using designated init then
the few non-conforming can get a warning. This approach is more
complicate.  But it does not need to change the kernel.


> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? warning(e->pos, "%s%s%spositional init of field in %s %s, declared with attribute designated_init",
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ctype->ident ? "in initializer for " : "",
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ctype->ident ? ctype->ident->name : "",

ident->name has no guarantee of terminating by NUL.
You want to use "%.*s" with ident->size, ident->name here.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/