Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242AbZJJV57 (ORCPT ); Sat, 10 Oct 2009 17:57:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752189AbZJJV57 (ORCPT ); Sat, 10 Oct 2009 17:57:59 -0400 Received: from gate.crashing.org ([63.228.1.57]:49585 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbZJJV56 (ORCPT ); Sat, 10 Oct 2009 17:57:58 -0400 Subject: Re: USB serial regression 2.6.31.1 -> 2.6.31.2 From: Benjamin Herrenschmidt To: Alan Stern Cc: Josua Dietze , Ben Efros , fangxiaozhi , Greg KH , Kernel development list , USB list , Hugh Blemings In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Sun, 11 Oct 2009 08:56:23 +1100 Message-Id: <1255211783.3387.14.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 21 > Further REQUEST SENSE commands therefore requested 96 bytes of data > instead of the standard 18 bytes. With LUN 0 this worked okay. But > with LUN 1 it didn't; the device reported a failure of the REQUEST > SENSE. This is what caused usb-storage to issue the device reset. > > After the reset usb-storage continued to ask for 96 bytes of sense > data, and LUN 1 continued to fail the commands. Hence the repeated > resets. Maybe a better approach would be to go back to 18 bytes when it fails, what do you think ? Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/