Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758907AbZJJXmQ (ORCPT ); Sat, 10 Oct 2009 19:42:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757098AbZJJXmP (ORCPT ); Sat, 10 Oct 2009 19:42:15 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:52566 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755013AbZJJXmO (ORCPT ); Sat, 10 Oct 2009 19:42:14 -0400 Date: Sun, 11 Oct 2009 00:42:19 +0100 From: Alan Cox To: John Kacur Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Jonathan Corbet , Peter Zijlstra , Frederic Weisbecker , Christoph Hellwig , Andrew Morton , Vincent Sanders , Ingo Molnar Subject: Re: [PATCH] sound_core.c: Remove BKL from soundcore_open Message-ID: <20091011004219.74c30f67@lxorguk.ukuu.org.uk> In-Reply-To: References: X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1156 Lines: 33 On Sun, 11 Oct 2009 01:24:14 +0200 (CEST) John Kacur wrote: > >From 030af455d4f54482130c8eccb47fe90aaba8808c Mon Sep 17 00:00:00 2001 > From: John Kacur > Date: Sat, 10 Oct 2009 23:39:56 +0200 > Subject: [PATCH] This code is already protected by spin_lock, and doesn't require the bkl Sorry but I don't think that is true becaue of: spin_unlock(&sound_loader_lock); if(file->f_op->open) err = file->f_op->open(inode,file); So the underlying driver open method expects lock_kernel status and you don't propogate it down. You really need to track down each thing that can be called into here and fix it, or maybe just punt for the moment and push it down to { lock_kernel() err = file-f_op->open ... unlock_kernel() } so its obvious to the next person who takes up the war on the BKL what is to be tackled. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/