Date: Sun, 11 Oct 2009 17:59:54 +0200 (CEST)
From: John Kacur <jkacur@redhat.com>
To: Christoph Hellwig <hch@lst.de>
cc: linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com,
       Thomas Gleixner <tglx@linutronix.de>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [xfs-masters] INFO: possible circular locking dependency
 detected
In-Reply-To: <20091011124616.GA4081@lst.de>
Message-ID: <alpine.LFD.2.00.0910111759030.12574@localhost.localdomain>
References: <alpine.LFD.2.00.0910110108160.4921@localhost.localdomain> <20091011124616.GA4081@lst.de>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 951
Lines: 26


On Sun, 11 Oct 2009, Christoph Hellwig wrote:

> This has been around for a long time, the VM calls into fput and thus
> ->release with the mmap_sem held, which makes it really hard for a
> filesystem to avoid a lock inversion if it uses a lock both in ->release
> and the I/O path.
> 
> I have a workaround for this to only acquire the XFS iolock with a
> trylock in the release path and leave cleaning up stale preallocations
> until the final iput.  It's not pretty, but given that we're unlikely
> to see the VM fixed I might aswell finally send it for inclusion.
> 

In seems very easy and reliable to reproduce on my machine - so I am happy 
to test the patch here when you're ready.

Thanks

John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/