Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755917AbZJKQTO (ORCPT ); Sun, 11 Oct 2009 12:19:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755375AbZJKQTN (ORCPT ); Sun, 11 Oct 2009 12:19:13 -0400 Received: from casper.infradead.org ([85.118.1.10]:39246 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755216AbZJKQTM (ORCPT ); Sun, 11 Oct 2009 12:19:12 -0400 Date: Sun, 11 Oct 2009 09:19:04 -0700 From: Arjan van de Ven To: Alan Cox Cc: John Kacur , linux-kernel@vger.kernel.org, Thomas Gleixner , Frederic Weisbecker , Ingo Molnar , Christoph Hellwig , Jonathan Corbet , Andrew Morton , Vincent Sanders , linux-scsi@vger.kernel.org Subject: Re: [PATCH RFC] [PATCH] drivers/scsi/ch.c: Remove BKL in ch_open Message-ID: <20091011091904.60a64279@infradead.org> In-Reply-To: <20091011171403.13a018f0@lxorguk.ukuu.org.uk> References: <20091011153709.4438cf9c@lxorguk.ukuu.org.uk> <20091011082917.6ebbd810@infradead.org> <20091011165408.51d4f413@lxorguk.ukuu.org.uk> <20091011090313.1b8f0eb1@infradead.org> <20091011171403.13a018f0@lxorguk.ukuu.org.uk> Organization: Intel X-Mailer: Claws Mail 3.7.2 (GTK+ 2.16.6; i586-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 42 On Sun, 11 Oct 2009 17:14:03 +0100 Alan Cox wrote: > > > But module load/unload does > > > > it does? > > > > looking at the code.... so far failing to find where. > > Interesting - it used to and there is code that still relies on that. I can't find that to be the case anymore though > > The more general problem of > > register_chrdev > open > do something > error > unload > whoops > > definitely needs looking at however. absolutely we used to have the same issue with networking devices, and there it ended up with a split "allocate" and "register" -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/