Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753761AbZJLGGc (ORCPT ); Mon, 12 Oct 2009 02:06:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752572AbZJLGGb (ORCPT ); Mon, 12 Oct 2009 02:06:31 -0400 Received: from cantor.suse.de ([195.135.220.2]:58877 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbZJLGGb (ORCPT ); Mon, 12 Oct 2009 02:06:31 -0400 Date: Mon, 12 Oct 2009 08:05:51 +0200 Message-ID: From: Takashi Iwai To: John Kacur Cc: Frederic Weisbecker , Alan Cox , linux-kernel@vger.kernel.org, Thomas Gleixner , Jonathan Corbet , Peter Zijlstra , Christoph Hellwig , Andrew Morton , Vincent^M^J Sanders , Ingo Molnar Subject: Re: [PATCH] sound_core.c: Remove BKL from soundcore_open In-Reply-To: References: <20091011004219.74c30f67@lxorguk.ukuu.org.uk> <20091011113317.GA4901@nowhere> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 20 At Sun, 11 Oct 2009 14:41:15 +0200 (CEST), John Kacur wrote: > > @@ -631,17 +629,17 @@ static int soundcore_open(struct inode *inode, struct file *file) > file->f_op = new_fops; > spin_unlock(&sound_loader_lock); > if(file->f_op->open) > + lock_kernel(); > err = file->f_op->open(inode,file); > + unlock_kernel(); You certainly want braces around here, no? Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/