Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755908AbZJLKN1 (ORCPT ); Mon, 12 Oct 2009 06:13:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755894AbZJLKNZ (ORCPT ); Mon, 12 Oct 2009 06:13:25 -0400 Received: from mail-fx0-f227.google.com ([209.85.220.227]:37231 "EHLO mail-fx0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755893AbZJLKNY convert rfc822-to-8bit (ORCPT ); Mon, 12 Oct 2009 06:13:24 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=rMoMVXWBwpSK2LqcnG2wYWV2ws0MiNwcyUuZxpsFXP/n+lPGSbqCoriIpSLK5xm+cN xgXNmOGAne1rTJVYC1g4FkdHp61Id9BLokLOVQwJ25jxg1HAx48rHZKv0DJA5A475a4R Ba5E5v7NTmgKy0XO5l/bwHu7b3FCdAz6iZFSE= MIME-Version: 1.0 In-Reply-To: References: <20091007222733.1684.32035.stgit@dhcp-100-2-132.bos.redhat.com> <20091007222807.1684.26880.stgit@dhcp-100-2-132.bos.redhat.com> Date: Mon, 12 Oct 2009 12:12:47 +0200 Message-ID: Subject: Re: [PATCH tracing/kprobes v3 4/7] tracing/kprobes: Avoid field name confliction From: =?ISO-8859-1?Q?Fr=E9d=E9ric_Weisbecker?= To: Masami Hiramatsu Cc: Steven Rostedt , Ingo Molnar , lkml , systemtap , DLE , Thomas Gleixner , Arnaldo Carvalho de Melo , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Christoph Hellwig , Ananth N Mavinakayanahalli , Jim Keniston , "Frank Ch. Eigler" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2405 Lines: 70 Le 12 octobre 2009 12:10, Fr?d?ric Weisbecker a ?crit : > 2009/10/8 Masami Hiramatsu : >> Check whether the argument name is conflict with other field names. >> >> Changes in v3: >> ?- Check strcmp() == 0 instead of !strcmp(). >> >> Changes in v2: >> ?- Add common_lock_depth to reserved name list. >> >> Signed-off-by: Masami Hiramatsu >> Cc: Frederic Weisbecker >> Cc: Ingo Molnar >> Cc: Thomas Gleixner >> Cc: Arnaldo Carvalho de Melo >> Cc: Steven Rostedt >> Cc: Mike Galbraith >> Cc: Paul Mackerras >> Cc: Peter Zijlstra >> Cc: Christoph Hellwig >> Cc: Ananth N Mavinakayanahalli >> Cc: Jim Keniston >> Cc: Frank Ch. Eigler >> --- >> >> ?kernel/trace/trace_kprobe.c | ? 65 +++++++++++++++++++++++++++++++++++-------- >> ?1 files changed, 53 insertions(+), 12 deletions(-) >> >> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c >> index 030f28c..e3b824a 100644 >> --- a/kernel/trace/trace_kprobe.c >> +++ b/kernel/trace/trace_kprobe.c >> @@ -38,6 +38,25 @@ >> ?#define MAX_EVENT_NAME_LEN 64 >> ?#define KPROBE_EVENT_SYSTEM "kprobes" >> >> +/* Reserved field names */ >> +#define FIELD_STRING_IP "ip" >> +#define FIELD_STRING_NARGS "nargs" >> +#define FIELD_STRING_RETIP "ret_ip" >> +#define FIELD_STRING_FUNC "func" > > > If it might conflict, then we should minimize the possibilities for > that to happen. > > What if we prefix these fields with kprobed_ ? > > kprobed_ip > kprobed_nargs > kprobed_ret_ip > kprobed_func > > We are lucky there in that kprobe functions in the kernel can't be kprobed > so it's safe wrt the conflict in the same namespace. > > And we can further schrink the kprobed prefixes in userspace post processing. > > (If you agree with the above, that can be done incrementally). > > Thanks. I'm an idiot. I should have looked at the 5/7 patch before sending this reply. Just forget about what I said :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/