Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755655AbZJLKXU (ORCPT ); Mon, 12 Oct 2009 06:23:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755427AbZJLKXT (ORCPT ); Mon, 12 Oct 2009 06:23:19 -0400 Received: from hera.kernel.org ([140.211.167.34]:41607 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755352AbZJLKXS (ORCPT ); Mon, 12 Oct 2009 06:23:18 -0400 Message-ID: <4AD3033C.8010503@kernel.org> Date: Mon, 12 Oct 2009 19:21:48 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: cl@linux-foundation.org CC: linux-kernel@vger.kernel.org, Pekka Enberg , Mel Gorman , Mathieu Desnoyers Subject: Re: [this_cpu_xx V6 3/7] Use this_cpu operations in slub References: <20091007211024.442168959@gentwo.org> <20091007211052.614790286@gentwo.org> <4AD302A8.4010409@kernel.org> In-Reply-To: <4AD302A8.4010409@kernel.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Mon, 12 Oct 2009 10:21:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 965 Lines: 33 Tejun Heo wrote: > Hello, > > cl@linux-foundation.org wrote: >> @@ -1507,7 +1498,7 @@ static inline void flush_slab(struct kme >> */ >> static inline void __flush_cpu_slab(struct kmem_cache *s, int cpu) >> { >> - struct kmem_cache_cpu *c = get_cpu_slab(s, cpu); >> + struct kmem_cache_cpu *c = per_cpu_ptr(s->cpu_slab, cpu); >> >> if (likely(c && c->page)) >> flush_slab(s, c); >> @@ -1673,7 +1661,7 @@ new_slab: >> local_irq_disable(); >> >> if (new) { >> - c = get_cpu_slab(s, smp_processor_id()); >> + c = __this_cpu_ptr(s->cpu_slab); > > Shouldn't this be this_cpu_ptr() without the double underscore? Oh... another similar conversions in slab_alloc() and slab_free() too. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/