Return-Path: <linux-kernel-owner+w=401wt.eu-S1756027AbZJLKb4@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756027AbZJLKb4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 12 Oct 2009 06:31:56 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755132AbZJLKbz
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 12 Oct 2009 06:31:55 -0400
Received: from mail-bw0-f210.google.com ([209.85.218.210]:37811 "EHLO
	mail-bw0-f210.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754890AbZJLKbx convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 12 Oct 2009 06:31:53 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=GQ4RHerJZVH3eXhH2yMi+D9UFPDechEJE1jGIaoTB20tWCHNnUKUCxHH9RIbnQs6XP
         9abWQ+yQgifb8Gx5fITXSHDcsK1bUPEIEjwwrq7X54rmqGvPlbyB4t+mQ62E8mREmIp8
         F6z6pc6MY53dSAnGW0bCBjurv6KzojYScuS0Y=
MIME-Version: 1.0
In-Reply-To: <20091008211737.29299.14784.stgit@dhcp-100-2-132.bos.redhat.com>
References: <4ACE56EE.8060000@redhat.com>
	 <20091008211737.29299.14784.stgit@dhcp-100-2-132.bos.redhat.com>
Date: Mon, 12 Oct 2009 12:31:16 +0200
Message-ID: <c62985530910120331g42ff49a3pd043ef9c6923143e@mail.gmail.com>
Subject: Re: [PATCH tracing/kprobes v4] perf: Add perf probe subcommand for 
	kprobe-event setup helper
From: =?ISO-8859-1?Q?Fr=E9d=E9ric_Weisbecker?= <fweisbec@gmail.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
       lkml <linux-kernel@vger.kernel.org>,
       systemtap <systemtap@sources.redhat.com>,
       DLE <dle-develop@lists.sourceforge.net>,
       Thomas Gleixner <tglx@linutronix.de>,
       Arnaldo Carvalho de Melo <acme@redhat.com>,
       Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Christoph Hellwig <hch@infradead.org>,
       Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
       Jim Keniston <jkenisto@us.ibm.com>,
       "Frank Ch. Eigler" <fche@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3820
Lines: 105

2009/10/8 Masami Hiramatsu <mhiramat@redhat.com>:
> Add perf probe subcommand for kprobe-event setup helper to perf command.
> This allows user to define kprobe events by C expressions (C line numbers,
> C function names, and C local variables).
>
> Usage
> -----
> ?perf probe [<options>] -P 'PROBEDEF' [-P 'PROBEDEF' ...]
>
> ? ?-k, --vmlinux <file> ?vmlinux/module pathname
> ? ?-P, --probe <p|r:[GRP/]NAME FUNC[+OFFS][@SRC]|@SRC:LINE [ARG ...]>
> ? ? ? ? ? ? ? ? ? ? ? ? ?probe point definition, where
> ? ? ? ? ? ? ? ?p: ? ? ?kprobe probe
> ? ? ? ? ? ? ? ?r: ? ? ?kretprobe probe
> ? ? ? ? ? ? ? ?GRP: ? ?Group name (optional)
> ? ? ? ? ? ? ? ?NAME: ? Event name
> ? ? ? ? ? ? ? ?FUNC: ? Function name
> ? ? ? ? ? ? ? ?OFFS: ? Offset from function entry (in byte)
> ? ? ? ? ? ? ? ?SRC: ? ?Source code path
> ? ? ? ? ? ? ? ?LINE: ? Line number
> ? ? ? ? ? ? ? ?ARG: ? ?Probe argument (local variable name or
> ? ? ? ? ? ? ? ? ? ? ? ?kprobe-tracer argument format is supported.)
>
> Changes in v4:
> ?- Add _GNU_SOURCE macro for strndup().
>
> Changes in v3:
> ?- Remove -r option because perf always be used for online kernel.
> ?- Check malloc/calloc results.
>
> Changes in v2:
> ?- Check synthesized string length.
> ?- Rename perf kprobe to perf probe.
> ?- Use spaces for separator and update usage comment.
> ?- Check error paths in parse_probepoint().
> ?- Check optimized-out variables.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc: Jim Keniston <jkenisto@us.ibm.com>
> Cc: Frank Ch. Eigler <fche@redhat.com>
> ---
>
[...]
> +/* Default vmlinux search paths */
> +#define NR_SEARCH_PATH 3
> +const char *default_search_path[NR_SEARCH_PATH] = {
> +"/lib/modules/%s/build/vmlinux", ? ? ? ? ? ? ? /* Custom build kernel */
> +"/usr/lib/debug/lib/modules/%s/vmlinux", ? ? ? /* Red Hat debuginfo */
> +"/boot/vmlinux-debug-%s", ? ? ? ? ? ? ? ? ? ? ?/* Ubuntu */
> +};
[...]
> +static int open_default_vmlinux(void)
> +{
> + ? ? ? struct utsname uts;
> + ? ? ? char fname[MAX_PATH_LEN];
> + ? ? ? int fd, ret, i;
> +
> + ? ? ? ret = uname(&uts);
> + ? ? ? if (ret) {
> + ? ? ? ? ? ? ? debug("uname() failed.\n");
> + ? ? ? ? ? ? ? return -errno;
> + ? ? ? }
> + ? ? ? session.release = uts.release;
> + ? ? ? for (i = 0; i < NR_SEARCH_PATH; i++) {
> + ? ? ? ? ? ? ? ret = snprintf(fname, MAX_PATH_LEN,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?default_search_path[i], session.release);
> + ? ? ? ? ? ? ? if (ret >= MAX_PATH_LEN || ret < 0) {
> + ? ? ? ? ? ? ? ? ? ? ? debug("Filename(%d,%s) is too long.\n", i, uts.release);
> + ? ? ? ? ? ? ? ? ? ? ? errno = E2BIG;
> + ? ? ? ? ? ? ? ? ? ? ? return -E2BIG;
> + ? ? ? ? ? ? ? }
> + ? ? ? ? ? ? ? debug("try to open %s\n", fname);
> + ? ? ? ? ? ? ? fd = open(fname, O_RDONLY);
> + ? ? ? ? ? ? ? if (fd >= 0)
> + ? ? ? ? ? ? ? ? ? ? ? break;
> + ? ? ? }
> + ? ? ? return fd;
> +}


We have a kind of kernel path finder already inside perf. It might be
encapsulated
inside the load_kernel() helper, I don't remember exactly.

It would be better to make use of such centralized and already
existing facility.

The patchset looks good. I'll apply and push it soon.

Thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/