Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756478AbZJLNGy (ORCPT ); Mon, 12 Oct 2009 09:06:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755253AbZJLNGy (ORCPT ); Mon, 12 Oct 2009 09:06:54 -0400 Received: from mail-gx0-f212.google.com ([209.85.217.212]:58690 "EHLO mail-gx0-f212.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbZJLNGx convert rfc822-to-8bit (ORCPT ); Mon, 12 Oct 2009 09:06:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=fUABbYY+PNnQijLaw0Fok+GDTN0TOwffnGZ6y9UjyVBpTPK4RGIchEP2zDO5i3me70 rRhnN16vz+r/C87aEjdl0d1IdYF4nisXl97vAonQnY8PLFztptkMjrUO2aiI7hfaZQBr rybfMVHwb6I9H5SogVh90Rq5pCWN2LHjb3xa0= MIME-Version: 1.0 In-Reply-To: <20091012074221.GA19198@elte.hu> References: <20091012074221.GA19198@elte.hu> From: Mike Frysinger Date: Mon, 12 Oct 2009 09:05:57 -0400 Message-ID: <8bd0f97a0910120605q17a586dag29cf4ab6d89dd29d@mail.gmail.com> Subject: Re: [origin tree build failure] [PATCH] Revert "USB: musb: make HAVE_CLK support optional" To: Ingo Molnar Cc: Linus Torvalds , Greg KH , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 32 On Mon, Oct 12, 2009 at 03:42, Ingo Molnar wrote: > > * Linus Torvalds wrote: > >> As usual, please test this for regressions, both new and old. > >>       USB: musb: make HAVE_CLK support optional > > This USB/Blackfin commit broke the x86 build with these config options: > >  CONFIG_USB_MUSB_HDRC=y >  CONFIG_USB_MUSB_HOST=y >  # CONFIG_USB_MUSB_PERIPHERAL is not set >  # CONFIG_USB_MUSB_OTG is not set >  # CONFIG_USB_GADGET_MUSB_HDRC is not set >  CONFIG_USB_MUSB_HDRC_HCD=y >  CONFIG_MUSB_PIO_ONLY=y >  CONFIG_USB_MUSB_DEBUG=y > > Because a side-effect of the patch was that it enabled the driver on x86 > too which doesnt have HAVE_CLK. So this formerly embedded-only driver > got exposed on the more widely tested x86 platform. this is dumb. you're addressing unrealistic scenarios (randconfig) by reverting code for realistic scenarios. how about updating the already present arch depend string instead. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/