Date: Mon, 12 Oct 2009 07:29:40 -0700
From: Greg KH <gregkh@suse.de>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [origin tree build failure] [PATCH] Revert "USB: musb: make
 HAVE_CLK support optional"
Message-ID: <20091012142940.GB1114@suse.de>
References: <alpine.LFD.2.01.0910111446410.3438@localhost.localdomain>
 <20091012074221.GA19198@elte.hu>
 <8bd0f97a0910120605q17a586dag29cf4ab6d89dd29d@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8bd0f97a0910120605q17a586dag29cf4ab6d89dd29d@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1493
Lines: 40

On Mon, Oct 12, 2009 at 09:05:57AM -0400, Mike Frysinger wrote:
> On Mon, Oct 12, 2009 at 03:42, Ingo Molnar wrote:
> >
> > * Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> >> As usual, please test this for regressions, both new and old.
> >
> >> ? ? ? USB: musb: make HAVE_CLK support optional
> >
> > This USB/Blackfin commit broke the x86 build with these config options:
> >
> > ?CONFIG_USB_MUSB_HDRC=y
> > ?CONFIG_USB_MUSB_HOST=y
> > ?# CONFIG_USB_MUSB_PERIPHERAL is not set
> > ?# CONFIG_USB_MUSB_OTG is not set
> > ?# CONFIG_USB_GADGET_MUSB_HDRC is not set
> > ?CONFIG_USB_MUSB_HDRC_HCD=y
> > ?CONFIG_MUSB_PIO_ONLY=y
> > ?CONFIG_USB_MUSB_DEBUG=y
> >
> > Because a side-effect of the patch was that it enabled the driver on x86
> > too which doesnt have HAVE_CLK. So this formerly embedded-only driver
> > got exposed on the more widely tested x86 platform.
> 
> this is dumb.  you're addressing unrealistic scenarios (randconfig) by
> reverting code for realistic scenarios.  how about updating the
> already present arch depend string instead.

We want 'randconfig' to work, so this is not unrealistic.  Have you not
seen Randy Dunlap's zillion patches to get this to all work properly
over the past months?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/