Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932514AbZJLPCQ (ORCPT ); Mon, 12 Oct 2009 11:02:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932504AbZJLPCP (ORCPT ); Mon, 12 Oct 2009 11:02:15 -0400 Received: from smtp2.ultrahosting.com ([74.213.174.253]:35656 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932193AbZJLPCO (ORCPT ); Mon, 12 Oct 2009 11:02:14 -0400 Date: Mon, 12 Oct 2009 10:54:41 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Tejun Heo cc: linux-kernel@vger.kernel.org, Pekka Enberg , Mel Gorman , Mathieu Desnoyers Subject: Re: [this_cpu_xx V6 3/7] Use this_cpu operations in slub In-Reply-To: <4AD302A8.4010409@kernel.org> Message-ID: References: <20091007211024.442168959@gentwo.org> <20091007211052.614790286@gentwo.org> <4AD302A8.4010409@kernel.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 505 Lines: 15 On Mon, 12 Oct 2009, Tejun Heo wrote: > > - c = get_cpu_slab(s, smp_processor_id()); > > + c = __this_cpu_ptr(s->cpu_slab); > > Shouldn't this be this_cpu_ptr() without the double underscore? Interrupts are disabled so no concurrent fast path can occur. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/