Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757193AbZJLPde (ORCPT ); Mon, 12 Oct 2009 11:33:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756245AbZJLPde (ORCPT ); Mon, 12 Oct 2009 11:33:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53701 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754154AbZJLPdd (ORCPT ); Mon, 12 Oct 2009 11:33:33 -0400 Date: Mon, 12 Oct 2009 08:30:13 -0700 From: Greg KH To: Haiyang Zhang Cc: Hank Janssen , "linux-kernel@vger.kernel.org" , Tom Hanrahan , Hashir Abdi Subject: Re: [patch] Staging: hv: Fix vmbus load hang caused by wrong data packing Message-ID: <20091012153013.GA2062@suse.de> References: <1FB5E1D5CA062146B38059374562DF7212DEE3EC@TK5EX14MBXC130.redmond.corp.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1FB5E1D5CA062146B38059374562DF7212DEE3EC@TK5EX14MBXC130.redmond.corp.microsoft.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 45 On Sat, Oct 10, 2009 at 11:16:00PM +0000, Haiyang Zhang wrote: > From: Haiyang Zhang > > Fix vmbus load hang caused by wrong data packing. > > Cc: Hank Janssen > Cc: Greg Kroah-Hartman > Signed-off-by: Haiyang Zhang > > --- > diff --git a/drivers/staging/hv/ChannelMgmt.h b/drivers/staging/hv/ChannelMgmt.h > index a839d8f..3f18584 100644 > --- a/drivers/staging/hv/ChannelMgmt.h > +++ b/drivers/staging/hv/ChannelMgmt.h > @@ -30,6 +30,8 @@ > #include "VmbusChannelInterface.h" > #include "VmbusPacketFormat.h" > > +#pragma pack(push,1) > + > /* Version 1 messages */ > enum vmbus_channel_message_type { > ChannelMessageInvalid = 0, > @@ -54,24 +56,24 @@ enum vmbus_channel_message_type { > ChannelMessageViewRangeRemove = 18, > #endif > ChannelMessageCount > -} __attribute__((packed)); Why the change here? Isn't this doing the same thing? And I'm guessing that not all of these structures are needing to be packed, right? Are they all shared across the HV boundry? And is this fixing the problem that Hank and users have reported with the current code? Does this need to get into the 2.6.32 release? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/