Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932788AbZJLQsb (ORCPT ); Mon, 12 Oct 2009 12:48:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932460AbZJLQsb (ORCPT ); Mon, 12 Oct 2009 12:48:31 -0400 Received: from elettra.colt-to.towertech.it ([213.215.222.70]:35900 "EHLO elettra.colt-to.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932369AbZJLQsa (ORCPT ); Mon, 12 Oct 2009 12:48:30 -0400 Date: Mon, 12 Oct 2009 18:47:39 +0200 From: Alessandro Zummo To: Atsushi Nemoto Cc: Andrew Sharp , Thomas Hommel , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 1/2] rtc-ds1511: Fix races around device registration Message-ID: <20091012184739.46bb1052@i1501.lan.towertech.it> In-Reply-To: <1255365461-5732-1-git-send-email-anemo@mba.ocn.ne.jp> References: <1255365461-5732-1-git-send-email-anemo@mba.ocn.ne.jp> Organization: Tower Technologies X-Mailer: Sylpheed X-This-Is-A-Real-Message: Yes Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 26 On Tue, 13 Oct 2009 01:37:40 +0900 Atsushi Nemoto wrote: > * Call dev_set_drvdata before rtc device creation > * Use its own spinlock instead of rtc->irq_lock why? > * Check pdata->rtc before calling rtc_update_irq > * Use {alarm,update}_irq_enable and remove ioctl routine > * Use devres APIs and simplify error/remove path -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/