Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932980AbZJLRsK (ORCPT ); Mon, 12 Oct 2009 13:48:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932633AbZJLRsJ (ORCPT ); Mon, 12 Oct 2009 13:48:09 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41347 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932481AbZJLRsI (ORCPT ); Mon, 12 Oct 2009 13:48:08 -0400 Date: Mon, 12 Oct 2009 10:46:27 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Artem Bityutskiy cc: Simon Kagstrom , Ingo Molnar , David Woodhouse , LKML , "Koskinen Aaro (Nokia-D/Helsinki)" , linux-mtd , Andrew Morton , Alan Cox Subject: Re: [PATCH] panic.c: export panic_on_oops In-Reply-To: Message-ID: References: <1255241458-11665-1-git-send-email-dedekind1@gmail.com> <20091012111545.GB8857@elte.hu> <1255346731.9659.31.camel@localhost> <20091012113758.GB11035@elte.hu> <20091012140149.6789efab@marrow.netinsight.se> <20091012120951.GA16799@elte.hu> <1255349748.10605.13.camel@macbook.infradead.org> <20091012122023.GA19365@elte.hu> <20091012150650.51a4b4dc@marrow.netinsight.se> <20091012131528.GC25464@elte.hu> <20091012153937.0dcd73e5@marrow.netinsight.se> <1255368557.27022.226.camel@localhost> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 25 On Mon, 12 Oct 2009, Linus Torvalds wrote: > > Once you do the final flush in a controlled place _after_ you've printed > out all the oops information, you simply don't care about locks any more. > Because if you were holding critical locks, you're done anyway. > > Sure, maybe you want to do a "trylock()" and skip the oops flush entirely > in the mtd layer if you can't do it, but it's the "let's use a workqueue" > or something that doesn't seem to make a lot of sense to me. Side note: I don't actually care deeply. Once it's all inside some driver, and once it's not messing up the console layer, I don't think the small details matter all that much. I just think it's likely to be a sign of something wrong if you need to use workqueues to flush - it probably means that the most interesting oopses will never make it to the mtd device in the first place. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/