DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=VkYfcb4vs1hPalyD1a6zYYKgH/VGdpl/B1DaTaWHBONlpvpVQWJMUjd9sk1LNtN10E8GVkqLei52Z5u1LuxU4Mm2lSrPj+XtYbKGW3MGVTZ8hGHm1vkfoaTsQ+QMOQrn;
Date: Mon, 12 Oct 2009 11:30:55 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Bernhard Walle <bernhard@bwalle.de>
Cc: Andi Kleen <andi@firstfloor.org>, akpm@linuxfoundation.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Always print panic message on current console
Message-ID: <20091012113055.13d3b7e3@jbarnes-g45>
In-Reply-To: <4AD37478.2070204@bwalle.de>
References: <1255207870-24496-1-git-send-email-bernhard@bwalle.de>
	<1255207870-24496-6-git-send-email-bernhard@bwalle.de>
	<87d44sh5uj.fsf@basil.nowhere.org>
	<4AD37478.2070204@bwalle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1718
Lines: 41

On Mon, 12 Oct 2009 20:24:56 +0200
Bernhard Walle <bernhard@bwalle.de> wrote:

> Andi Kleen schrieb:
> > Bernhard Walle <bernhard@bwalle.de> writes:
> > 
> >> The kernel offers with TIOCL_GETKMSGREDIRECT ioctl() the
> >> possibility to redirect the kernel messages to a specific console.
> >>
> >> However, since it's not possible to switch to the kernel message
> >> console after a panic(), it would be nice if the kernel would
> >> print the panic message on the current console.
> > 
> > The basic idea is good, but you really need to call this in a lot
> > more places, which print some addition needed information before
> > the panic. The one liner panic is often not enough to decide what
> > went wrong. Example are machine checks, oopses, probably more.
> > 
> > In general for the recent work to switch the video mode on panic
> > we need a generalized hook for this anyways, so you could use
> > some generalized function.
> 
> Is that video switch called in a panic notifier list or does that
> introduce a new hook?
> 
> One problem is that kexec is executed before the panic notifier. Which
> is okay for printk(), but it would be very good if the video switch
> would occur before kexec.

It's called in the panic notifier atm.  Yeah sounds like kexec vs
notifiers should be reordered a bit (or the current panic notifier
should be split into notify and "yes we actually failed to do anything"
cases).

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/