Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933182AbZJLT3R (ORCPT ); Mon, 12 Oct 2009 15:29:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757983AbZJLT3Q (ORCPT ); Mon, 12 Oct 2009 15:29:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45796 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757550AbZJLT3P (ORCPT ); Mon, 12 Oct 2009 15:29:15 -0400 Message-ID: <4AD3842E.4050805@redhat.com> Date: Mon, 12 Oct 2009 15:31:58 -0400 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Ingo Molnar CC: Frederic Weisbecker , Steven Rostedt , lkml , systemtap , DLE , Thomas Gleixner , Arnaldo Carvalho de Melo , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Christoph Hellwig , Ananth N Mavinakayanahalli , Jim Keniston , "Frank Ch. Eigler" Subject: Re: [PATCH tracing/kprobes v3 6/7] perf: Add perf probe subcommand for kprobe-event setup helper References: <20091007222733.1684.32035.stgit@dhcp-100-2-132.bos.redhat.com> <20091007222822.1684.3251.stgit@dhcp-100-2-132.bos.redhat.com> <20091012190303.GA4748@nowhere> <20091012190707.GJ17138@elte.hu> In-Reply-To: <20091012190707.GJ17138@elte.hu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2562 Lines: 70 Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > >> On Wed, Oct 07, 2009 at 06:28:23PM -0400, Masami Hiramatsu wrote: >>> Add perf probe subcommand for kprobe-event setup helper to perf command. >>> This allows user to define kprobe events by C expressions (C line numbers, >>> C function names, and C local variables). >>> >> >> >> My libdwarf.h and dwarf.h are available through and >> , these are in /usr/include >> >> But even by fixing the include path in the makefile and probe-finder.h, >> I get the following build error: >> >> util/probe-finder.c: In function ‘die_get_entrypc’: >> util/probe-finder.c:222: erreur: ‘Dwarf_Ranges’ undeclared (first use in this function) >> util/probe-finder.c:222: erreur: (Each undeclared identifier is reported only once >> util/probe-finder.c:222: erreur: for each function it appears in.) >> util/probe-finder.c:222: erreur: ‘ranges’ undeclared (first use in this function) >> cc1: warnings being treated as errors >> util/probe-finder.c:223: erreur: ISO C90 forbids mixed declarations and code >> util/probe-finder.c:247: erreur: implicit declaration of function ‘dwarf_get_ranges’ >> util/probe-finder.c:247: erreur: nested extern declaration of ‘dwarf_get_ranges’ >> util/probe-finder.c:251: erreur: implicit declaration of function ‘dwarf_ranges_dealloc’ >> util/probe-finder.c:251: erreur: nested extern declaration of ‘dwarf_ranges_dealloc’ >> make: *** [util/probe-finder.o] Erreur 1 >> >> >> I remember we talked about that before, but I don't remember well why it happened. >> This is because of a libdwarf version or something, right? Yeah, you may use an old version. >> >> Which one should I pick? Mine is: >> >> libdwarf.h >> >> $Revision: #9 $ $Date: 2008/01/17 $ AFAICS, the revision tag is not updated :( I'm usually using libdwarf later than 20090324, and dwarf_get_ranges() was introduced from 20081231. > > if it's possible to still have a single set of APIs it would be nice to > auto-detect and massage all these libdwarf versions into a single > backend within perf. Sure, it's not so hard to check APIs. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/