Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758059AbZJLTuJ (ORCPT ); Mon, 12 Oct 2009 15:50:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758044AbZJLTuH (ORCPT ); Mon, 12 Oct 2009 15:50:07 -0400 Received: from ey-out-2122.google.com ([74.125.78.27]:34690 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758018AbZJLTuE (ORCPT ); Mon, 12 Oct 2009 15:50:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=CUQ00ZjKNQDqJDMWjjzqfocGHbD0j4m9jMno9lOkE34eIeQlbLXj5/fe2rgMvm5GLm VGX2Wk13sfgJbfXoCP1tZ+OhauFkcE0KriovEgFEPUf9SHAyERsbMeJJqviksenqbocT 5GYOJh5g+xcFRQh1iOrIgdtN9wm+uY0r53uw0= Date: Mon, 12 Oct 2009 21:48:54 +0200 From: Frederic Weisbecker To: Masami Hiramatsu Cc: Steven Rostedt , Ingo Molnar , lkml , systemtap , DLE , Thomas Gleixner , Arnaldo Carvalho de Melo , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Christoph Hellwig , Ananth N Mavinakayanahalli , Jim Keniston , "Frank Ch. Eigler" Subject: Re: [PATCH tracing/kprobes v3 4/7] tracing/kprobes: Avoid field name confliction Message-ID: <20091012194852.GB4748@nowhere> References: <20091007222733.1684.32035.stgit@dhcp-100-2-132.bos.redhat.com> <20091007222807.1684.26880.stgit@dhcp-100-2-132.bos.redhat.com> <20091012173752.GB5059@nowhere> <4AD37FEF.9050807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD37FEF.9050807@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 43 On Mon, Oct 12, 2009 at 03:13:51PM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: >> The conflict issue might not be obvious for a user desperately trying to set >> a kprobe. Even for other failcases, it might not be obvious (blacklisted >> symbols, syntax errors...) >> >> May be should you improve the error granularity and print a KERN_DEBUG >> message? > > Agreed, and kprobes error handling should be improved too (in the most cases, > it just returns -EINVAL). > > Thank you. > And btw, I'm enable to create a probe, neither through ftrace nor perf: $ sudo ./perf probe -P 'p:sys_close sys_close $retval' Adding new event: p:sys_close sys_close+0 $retval Error: Failed to create event: Invalid argument # echo 'p:sys_open sys_open $retval' > /debug/tracing/kprobe_events bash: echo: write error : Invalid argument I suspect I missed something very obvious with the syntax :) I've applied your patches in: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git tracing/kprobes Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/