Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758228AbZJLVVo (ORCPT ); Mon, 12 Oct 2009 17:21:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757920AbZJLVVn (ORCPT ); Mon, 12 Oct 2009 17:21:43 -0400 Received: from gate.crashing.org ([63.228.1.57]:35317 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbZJLVVm (ORCPT ); Mon, 12 Oct 2009 17:21:42 -0400 Subject: Re: USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH] From: Benjamin Herrenschmidt To: Alan Stern Cc: Ben Efros , Josua Dietze , fangxiaozhi , Greg KH , Kernel development list , USB list , Hugh Blemings In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Tue, 13 Oct 2009 08:19:46 +1100 Message-Id: <1255382386.2192.125.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 899 Lines: 25 On Mon, 2009-10-12 at 10:58 -0400, Alan Stern wrote: > Except that this is wrong. We can retry if temp_result == > USB_STOR_TRANSPORT_FAILURE, but we should not retry if temp_result == > USB_STOR_TRANSPORT_ERROR. > > Alan Stern > > P.S.: In case you don't already know... TRANSPORT_FAILURE means we > were able to communicate with the device, and it told us that it > couldn't carry out the command. TRANSPORT_ERROR means we weren't able > to communicate with the device. Ah good, I was wondering about precisely that (discriminating the errors more intelligently). No point retrying if the device was yanked or went totally dead. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/