Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758465AbZJLVcU (ORCPT ); Mon, 12 Oct 2009 17:32:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758370AbZJLVcT (ORCPT ); Mon, 12 Oct 2009 17:32:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbZJLVcS (ORCPT ); Mon, 12 Oct 2009 17:32:18 -0400 Message-ID: <4AD3A13D.2090906@redhat.com> Date: Mon, 12 Oct 2009 17:35:57 -0400 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, ananth@in.ibm.com, tglx@linutronix.de, mhiramat@redhat.com CC: linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/cleanups] x86: use kernel_stack_pointer() in kprobes.c References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1447 Lines: 41 tip-bot for H. Peter Anvin wrote: > Commit-ID: 98272ed0d2e6509fe7dc571e77956c99bf653bb6 > Gitweb: http://git.kernel.org/tip/98272ed0d2e6509fe7dc571e77956c99bf653bb6 > Author: H. Peter Anvin > AuthorDate: Mon, 12 Oct 2009 14:14:10 -0700 > Committer: H. Peter Anvin > CommitDate: Mon, 12 Oct 2009 14:19:35 -0700 > > x86: use kernel_stack_pointer() in kprobes.c > > The way to obtain a kernel-mode stack pointer from a struct pt_regs in > 32-bit mode is "subtle": the stack doesn't actually contain the stack > pointer, but rather the location where it would have been marks the > actual previous stack frame. For clarity, use kernel_stack_pointer() > instead of coding this weirdness explicitly. > > Signed-off-by: H. Peter Anvin > Cc: Ananth N Mavinakayanahalli > Cc: Anil S Keshavamurthy > Cc: "David S. Miller" > Cc: Masami Hiramatsu Acked-by: Masami Hiramatsu Thank you for fixing it! -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/