Message-ID: <4AD3A178.2080903@redhat.com>
Date: Mon, 12 Oct 2009 17:36:56 -0400
From: Masami Hiramatsu <mhiramat@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Thunderbird/3.0b4
MIME-Version: 1.0
To: Frederic Weisbecker <fweisbec@gmail.com>
CC: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
       lkml <linux-kernel@vger.kernel.org>,
       systemtap <systemtap@sources.redhat.com>,
       DLE <dle-develop@lists.sourceforge.net>,
       Thomas Gleixner <tglx@linutronix.de>,
       Arnaldo Carvalho de Melo <acme@redhat.com>,
       Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Christoph Hellwig <hch@infradead.org>,
       Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
       Jim Keniston <jkenisto@us.ibm.com>,
       "Frank Ch. Eigler" <fche@redhat.com>
Subject: Re: [PATCH tracing/kprobes v3 3/7] tracing/kprobes: Rename special
 variables
References: <20091007222733.1684.32035.stgit@dhcp-100-2-132.bos.redhat.com> <20091007222759.1684.3319.stgit@dhcp-100-2-132.bos.redhat.com> <4AD39D89.6070609@redhat.com> <20091012212824.GE4748@nowhere>
In-Reply-To: <20091012212824.GE4748@nowhere>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2045
Lines: 69

Frederic Weisbecker wrote:
> On Mon, Oct 12, 2009 at 05:20:09PM -0400, Masami Hiramatsu wrote:
>> Masami Hiramatsu wrote:
>>> @@ -427,28 +427,17 @@ static int parse_probe_vars(char *arg, struct fetch_func *ff, int is_return)
>>>    	int ret = 0;
>>>    	unsigned long param;
>>>
>>> -	switch (arg[0]) {
>>> -	case 'a':	/* argument */
>>> -		ret = strict_strtoul(arg + 1, 10,&param);
>>> -		if (ret || param>   PARAM_MAX_ARGS)
>>> -			ret = -EINVAL;
>>> -		else {
>>> -			ff->func = fetch_argument;
>>> -			ff->data = (void *)param;
>>> -		}
>>> -		break;
>>> -	case 'r':	/* retval or retaddr */
>>> -		if (is_return&&   arg[1] == 'v') {
>>> +	if (strcmp(arg, "retval") == 0) {
>>> +		if (is_return) {
>>>    			ff->func = fetch_retvalue;
>>>    			ff->data = NULL;
>>>    		} else
>>>    			ret = -EINVAL;
>>> -		break;
>>> -	case 's':	/* stack */
>>> -		if (arg[1] == 'a') {
>>> +	} else if (strncmp(arg, "stack", 5) == 0) {
>>> +		if (arg[5] == '\0') {
>>>    			ff->func = fetch_stack_address;
>>>    			ff->data = NULL;
>>> -		} else {
>>> +		} else if (isdigit(arg[5])) {
>>>    			ret = strict_strtoul(arg + 1, 10,&param);
>>                                               ^^^^^^^ this should be arg + 5.
>>
>>> @@ -456,11 +445,18 @@ static int parse_probe_vars(char *arg, struct fetch_func *ff, int is_return)
>>>    				ff->func = fetch_stack;
>>>    				ff->data = (void *)param;
>>>    			}
>>> +		} else
>>> +			ret = -EINVAL;
>>> +	} else if (strncmp(arg, "arg", 3) == 0&&   isdigit(arg[4])) {
>
>
>
> And this should be isdigit(arg[3]) actually, what you want to test is the
> first character after arg, right?

Right. I'll fix it...


Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/