Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933531AbZJLWfV (ORCPT ); Mon, 12 Oct 2009 18:35:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933523AbZJLWfU (ORCPT ); Mon, 12 Oct 2009 18:35:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56459 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933477AbZJLWfT (ORCPT ); Mon, 12 Oct 2009 18:35:19 -0400 Date: Tue, 13 Oct 2009 00:33:21 +0200 (CEST) From: John Kacur X-X-Sender: jkacur@localhost.localdomain To: linux-kernel@vger.kernel.org, Thomas Gleixner cc: Frederic Weisbecker , Vincent Sanders , Ingo Molnar , Christoph Hellwig , Alan Cox , Andrew Morton , Jonathan Corbet , Mike Frysinger , David Howells , Yoshinori Sato , Roman Zippel , Greg Ungerer , David Howells , Koichi Yasutake Subject: [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: Remove the BKL from sys_execve In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1724 Lines: 56 >From b9b41b5a546ed0202c099f0d973da4df9aea314a Mon Sep 17 00:00:00 2001 From: John Kacur Date: Mon, 12 Oct 2009 22:44:40 +0200 Subject: [PATCH] arch/blackfin/kernel/process.c: Remove the BKL from sys_execve This looks like a cut-and-paste job. For example, compare this function to sys_execve in arch/x86/kernel/process_64.c and it is almost line by line the same, except the one in x86 nolonger has the big kernel lock. All of the functions called between the lock are generic and not specific to blackfin - thus, I believe it is safe to remove the bkl here. Signed-off-by: John Kacur --- arch/blackfin/kernel/process.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c index 430ae39..7d9c975 100644 --- a/arch/blackfin/kernel/process.c +++ b/arch/blackfin/kernel/process.c @@ -215,22 +215,18 @@ copy_thread(unsigned long clone_flags, /* * sys_execve() executes a new program. */ - asmlinkage int sys_execve(char __user *name, char __user * __user *argv, char __user * __user *envp) { int error; char *filename; struct pt_regs *regs = (struct pt_regs *)((&name) + 6); - lock_kernel(); filename = getname(name); error = PTR_ERR(filename); if (IS_ERR(filename)) - goto out; + return error; error = do_execve(filename, argv, envp, regs); putname(filename); - out: - unlock_kernel(); return error; } -- 1.6.0.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/