Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758668AbZJMAEQ (ORCPT ); Mon, 12 Oct 2009 20:04:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758622AbZJMAEP (ORCPT ); Mon, 12 Oct 2009 20:04:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41420 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758611AbZJMAEP (ORCPT ); Mon, 12 Oct 2009 20:04:15 -0400 Date: Mon, 12 Oct 2009 16:58:06 -0700 From: Greg KH To: "Templin, Fred L" Cc: Greg KH , David Miller , "contact@saschahlusiak.de" , "yoshfuji@linux-ipv6.org" , "linux-kernel@vger.kernel.org" , "stable@kernel.org" , "akpm@linux-foundation.org" , "torvalds@linux-foundation.org" , "stable-review@kernel.org" , "alan@lxorguk.ukuu.org.uk" Subject: Re: [stable] [patch 37/37] sit: fix off-by-one inipip6_tunnel_get_prl Message-ID: <20091012235806.GA25153@suse.de> References: <20091009233411.852013234@mini.kroah.org> <20091009233440.786680001@mini.kroah.org> <12F4112206976147A34FEC0277597CCF27A416492F@XCH-NW-15V.nw.nos.boeing.com> <20091009.204231.204042155.davem@davemloft.net> <20091012220445.GB31010@kroah.com> <12F4112206976147A34FEC0277597CCF27A4164C1A@XCH-NW-15V.nw.nos.boeing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12F4112206976147A34FEC0277597CCF27A4164C1A@XCH-NW-15V.nw.nos.boeing.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2301 Lines: 59 On Mon, Oct 12, 2009 at 04:29:53PM -0700, Templin, Fred L wrote: > Greg, > > > -----Original Message----- > > From: Greg KH [mailto:greg@kroah.com] > > Sent: Monday, October 12, 2009 3:05 PM > > To: David Miller > > Cc: Templin, Fred L; contact@saschahlusiak.de; yoshfuji@linux-ipv6.org; gregkh@suse.de; linux- > > kernel@vger.kernel.org; stable@kernel.org; akpm@linux-foundation.org; torvalds@linux-foundation.org; > > stable-review@kernel.org; alan@lxorguk.ukuu.org.uk > > Subject: Re: [stable] [patch 37/37] sit: fix off-by-one inipip6_tunnel_get_prl > > > > On Fri, Oct 09, 2009 at 08:42:31PM -0700, David Miller wrote: > > > From: "Templin, Fred L" > > > Date: Fri, 9 Oct 2009 17:34:49 -0700 > > > > > > > Wait a moment - I remember now that this code came > > > > from Yoshifuji, and I believe there was a reason for > > > > the cmax+1. The application is expected to know this > > > > and to post a large enough buffer. > > > > > > > > Can we put this on hold until I have had a chance to > > > > check my e-mail archives and my local iproute changes > > > > (will respond on monday)? > > > > > > Sure, we can keep it out of -stable for now. > > > > > > But it is in Linus's tree so if you find we shouldn't do this > > > you'll need to send me a revert for net-2.6 > > > > > > Otherwise if it's good, you'll have to remind me to resubmit > > > it to -stable. > > > > Ah crap, I just commited it. > > > > Is it really broken? If so, I'll go revert it and cut a new release. > > > > Sorry about this. > > As I just mentioned to David, I tested and the patch is > good. To test, I allocated a buffer in the application > that was too small to hold the entire PRL. Without the > patch, the system crashes. With the patch, the kernel > returns the maximum number of PRL entries without > crashing and without overrunning the application's buffer. > > Please apply the patch if you have not already done so. Which patch? I need it to be in Linus's tree before we can apply it to a stable release. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/