Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757254AbZJMF21 (ORCPT ); Tue, 13 Oct 2009 01:28:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755945AbZJMF21 (ORCPT ); Tue, 13 Oct 2009 01:28:27 -0400 Received: from mail-pz0-f194.google.com ([209.85.222.194]:38053 "EHLO mail-pz0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755270AbZJMF20 (ORCPT ); Tue, 13 Oct 2009 01:28:26 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=i+TOh+k0pmwmMwHXQ2WuhJJAb98yYNHWJFxXxgUgaX6UJQchAmIEalxnoGhrcwWWc3 /8/4iY5dR5fdZkC0g4aJk3Bjy/gXZ4GAo/f9ezM32tWIEFIahywY4pAfvtoT1L3WHiAd aIGosBwmty936O7FzMCcJC/8y4clKdcvphpMU= MIME-Version: 1.0 In-Reply-To: <20091011.223502.77690228.davem@davemloft.net> References: <20091011.223502.77690228.davem@davemloft.net> Date: Tue, 13 Oct 2009 11:27:49 +0600 Message-ID: Subject: Re: [PATCH -mm] connector: Passing required parameter for function cn_add_callback. From: Rakib Mullick To: David Miller Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, zbr@ioremap.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 47 On 10/12/09, David Miller wrote: > From: Rakib Mullick > Date: Mon, 12 Oct 2009 08:44:33 +0600 > > > > */ > > -static void cn_proc_mcast_ctl(struct cn_msg *msg) > > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct > > netlink_skb_parms *nsp) > > > Your patches are unusable because your email client corrupts the > patch, here you can see it is splitting up long lines. > > Please fix this up and resubmit. Oops..... sorry for that. This is the second time I'm facing this problem. I'll try to fix it. I'm resubmitting the patch. Here I've recreate the patch to split the line into two. And it just reaches its 80 line mark. Hopefully it will be okay. Thanks, ---- Signed-off-by: Rakib Mullick --- linus/drivers/connector/cn_proc.c 2009-10-09 17:38:22.000000000 +0600 +++ rakib/drivers/connector/cn_proc.c 2009-10-13 12:29:37.000000000 +0600 @@ -225,9 +225,11 @@ static void cn_proc_ack(int err, int rcv /** * cn_proc_mcast_ctl - * @data: message sent from userspace via the connector + * @msg: message sent from userspace via the connector + * @nsp: remains unused but we need it to keep it */ -static void cn_proc_mcast_ctl(struct cn_msg *msg) +static void cn_proc_mcast_ctl(struct cn_msg *msg, + struct netlink_skb_parms *nsp) { enum proc_cn_mcast_op *mc_op = NULL; int err = 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/