Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758884AbZJMGN3 (ORCPT ); Tue, 13 Oct 2009 02:13:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756945AbZJMGN2 (ORCPT ); Tue, 13 Oct 2009 02:13:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49560 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756102AbZJMGN1 (ORCPT ); Tue, 13 Oct 2009 02:13:27 -0400 Date: Tue, 13 Oct 2009 08:12:50 +0200 Message-ID: From: Takashi Iwai To: Luca Tettamanti Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [BUG] GPF in snd_hda_intel In-Reply-To: <68676e00910121239qd2d87cbnbdab32efe041a65d@mail.gmail.com> References: <20091010130110.GA5445@nb-core2.darkstar.lan> <68676e00910121239qd2d87cbnbdab32efe041a65d@mail.gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3225 Lines: 85 At Mon, 12 Oct 2009 21:39:21 +0200, Luca Tettamanti wrote: > > On Mon, Oct 12, 2009 at 7:58 AM, Takashi Iwai wrote: > > At Sat, 10 Oct 2009 15:01:10 +0200, > > Luca Tettamanti wrote: > >> > >> Hello, > >> with current git kernel (bd381934) I see a GPF when the snd_hda_intel driver is > >> loaded; the regression is recent, 0eca52a works fine. > >> The machine is an ASUS laptop (F3Sa), this is the sound card: > > > > Could you load the snd-hda-intel module with probe_only=1 option, > > and give the output of "alsa-info.sh --no-upload" ? > > > > If 0eca52a worked, there are only a few changes regarding hda-intel. > > > > f8f25ba3563dab14b1c3ea4d829642b8a61ca5d7 > >    ALSA: hda - Add a workaround for ASUS A7K > > This is probably related; I haven't actually tested yet, but I have > one more information: I had "model=lenovo" in modprobe configuration. Ah, this is it. I can reproduce the problem with my emulator now. The patch below fixes the issue. > This was necessary because otherwise the driver applied the quirk for > Asus G1, resulting in no sound (see bug > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3513). > The driver works fine without "model" parameter (possibly due to the > removal of the quirk entry for the the G1); I get a warning about a > timeout when MSI is not enabled though: > > HDA Intel 0000:00:1b.0: PCI INT A disabled > HDA Intel 0000:00:1b.0: PCI INT A -> GSI 22 (level, low) -> IRQ 22 > HDA Intel 0000:00:1b.0: setting latency timer to 64 > hda_codec: ALC660-VD: BIOS auto-probing. > input: HDA Digital PCBeep as /devices/pci0000:00/0000:00:1b.0/input/input9 > hda-intel: azx_get_response timeout, switching to polling mode: last > cmd=0x018f0900 It's no critical error, but if enable_msi=1 helps, just keep the option. In 2.6.33, MSI will be enabled as default. thanks, Takashi --- >From 2d9c648295d7bc376305337d29f540a5e411f632 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Tue, 13 Oct 2009 08:06:55 +0200 Subject: [PATCH] ALSA: hda - Fix overflow of spec->init_verbs in patch_realtek.c ALC861-VD lenovo model causes overflow of spec->init_verbs entries due to the recent changes. Simply increase the array size to avoid the overflow. Reported-by: Luca Tettamanti Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_realtek.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 470fd74..c08ca66 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -275,7 +275,7 @@ struct alc_spec { struct snd_kcontrol_new *cap_mixer; /* capture mixer */ unsigned int beep_amp; /* beep amp value, set via set_beep_amp() */ - const struct hda_verb *init_verbs[5]; /* initialization verbs + const struct hda_verb *init_verbs[10]; /* initialization verbs * don't forget NULL * termination! */ -- 1.6.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/