Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933274AbZJMGmT (ORCPT ); Tue, 13 Oct 2009 02:42:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932948AbZJMGmS (ORCPT ); Tue, 13 Oct 2009 02:42:18 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38642 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932935AbZJMGmS (ORCPT ); Tue, 13 Oct 2009 02:42:18 -0400 Date: Mon, 12 Oct 2009 23:42:14 -0700 (PDT) Message-Id: <20091012.234214.110950674.davem@davemloft.net> To: rakib.mullick@gmail.com Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, zbr@ioremap.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm] connector: Passing required parameter for function cn_add_callback. From: David Miller In-Reply-To: References: <20091011.223502.77690228.davem@davemloft.net> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1243 Lines: 32 From: Rakib Mullick Date: Tue, 13 Oct 2009 11:27:49 +0600 > On 10/12/09, David Miller wrote: >> From: Rakib Mullick >> Date: Mon, 12 Oct 2009 08:44:33 +0600 >> >> >> > */ >> > -static void cn_proc_mcast_ctl(struct cn_msg *msg) >> > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct >> > netlink_skb_parms *nsp) >> >> >> Your patches are unusable because your email client corrupts the >> patch, here you can see it is splitting up long lines. >> >> Please fix this up and resubmit. > Oops..... sorry for that. This is the second time I'm facing this > problem. I'll try to fix it. > I'm resubmitting the patch. Here I've recreate the patch to split the > line into two. > And it just reaches its 80 line mark. Hopefully it will be okay. Upstream and my net-next-2.6 tree both have this function with the proper parameters, maybe Andrew's -mm tree had some conflicts and they weren't dealt with correctly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/