Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933666AbZJMHSv (ORCPT ); Tue, 13 Oct 2009 03:18:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933626AbZJMHSv (ORCPT ); Tue, 13 Oct 2009 03:18:51 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:43952 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933613AbZJMHSu (ORCPT ); Tue, 13 Oct 2009 03:18:50 -0400 Date: Tue, 13 Oct 2009 09:18:05 +0200 From: Ingo Molnar To: Jiri Kosina Cc: Thomas Gleixner , "H. Peter Anvin" , Luming Yu , LKML Subject: Re: [trivial PATCH] fix typo in nmi.c of apic Message-ID: <20091013071805.GC13175@elte.hu> References: <3877989d0909102303m31066b01he38e8a295995c430@mail.gmail.com> <20091012202613.GB7648@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1930 Lines: 55 * Jiri Kosina wrote: > On Mon, 12 Oct 2009, Ingo Molnar wrote: > > > > > I came across x86/kernel/apic/nmi.c and found several typo. > > > > It's trivial in terms of doing nothing on changing execution logic. > > > I'd rather go this through x86 tree. Adding Ingo. > > > > > > > Ps. The patch is enclosed in attachment. The inline one > > > > is c&p of it for reading. > > > > > > > > > > > > Thanks, > > > > Luming > > > > > > > > Signed-off-by: Yu Luming > > > > > > > > nmi.c | 18 +++++++++--------- > > > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/arch/x86/kernel/apic/nmi.c b/arch/x86/kernel/apic/nmi.c > > > > index b3025b4..9ff1f6d 100644 > > > > --- a/arch/x86/kernel/apic/nmi.c > > > > +++ b/arch/x86/kernel/apic/nmi.c > > > > @@ -121,7 +121,7 @@ static void report_broken_nmi(int cpu, unsigned > > > > int *prev_nmi_count) > > > > atomic_dec(&nmi_active); > > > > } > > > > > > > > -static void __acpi_nmi_disable(void *__unused) > > > > +static void __apic_nmi_disable(void *__unused) > > > > that's correctly named, as a 'git grep acpi_nmi_disable' should reveal. > > I actually think that Luming Yu is right that the function is misnamed. > What does it have to do with ACPI? It's not misnamed - it is a facility provided by architecture code to the ACPI subsystem and hence named acpi_*(). See: 5d0e600: [PATCH] x86: fix laptop bootup hang in init_acpi() Other architectures could opt to implement the same quirk - but it has nothing to do with APIC. Yes, on x86 we use the local APIC to disable NMIs, but that has no effect on the naming of the facility ... Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/