Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933703AbZJMHzu (ORCPT ); Tue, 13 Oct 2009 03:55:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755949AbZJMHzt (ORCPT ); Tue, 13 Oct 2009 03:55:49 -0400 Received: from mail-yx0-f188.google.com ([209.85.210.188]:45709 "EHLO mail-yx0-f188.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753688AbZJMHzs (ORCPT ); Tue, 13 Oct 2009 03:55:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=XUXyy0l+v4/lzxELGHeLPjyFUdX+GWim5njZdEHvFrA++NW5/qyh3F56PzbfSoOETf l+uuSwxuHKSMs0itbmAowiWVuFnVQlXTsWY9VWZcxvoyGHpBSinAEVFto8ypUtKLhHZ2 OqhtwXITqDxDTxUIpJWHa6OM+ogjeSO9Ehu9M= MIME-Version: 1.0 In-Reply-To: References: From: Mike Frysinger Date: Tue, 13 Oct 2009 03:54:52 -0400 Message-ID: <8bd0f97a0910130054v43fd9fbcv5316a5194ced4bfc@mail.gmail.com> Subject: Re: [PATCH 1/6 RFC] arch/blackfin/kernel/process.c: Remove the BKL from sys_execve To: John Kacur Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Frederic Weisbecker , Vincent Sanders , Ingo Molnar , Christoph Hellwig , Alan Cox , Andrew Morton , Jonathan Corbet , David Howells , Yoshinori Sato , Roman Zippel , Greg Ungerer , Koichi Yasutake Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 756 Lines: 18 On Mon, Oct 12, 2009 at 18:33, John Kacur wrote: > This looks like a cut-and-paste job. > For example, compare this function to sys_execve in > arch/x86/kernel/process_64.c > > and it is almost line by line the same, except the one in x86 nolonger has the > big kernel lock. All of the functions called between the lock are generic > and not specific to blackfin - thus, I believe it is safe to remove the > bkl here. and it still boots/runs fine, so np here Acked-by: Mike Frysinger -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/