Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759768AbZJMM7Z (ORCPT ); Tue, 13 Oct 2009 08:59:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759639AbZJMM7Y (ORCPT ); Tue, 13 Oct 2009 08:59:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54498 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759530AbZJMM7X (ORCPT ); Tue, 13 Oct 2009 08:59:23 -0400 Message-ID: <4AD479D9.90202@redhat.com> Date: Tue, 13 Oct 2009 09:00:09 -0400 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Ingo Molnar CC: Frederic Weisbecker , LKML , Thomas Gleixner , Arnaldo Carvalho de Melo , Steven Rostedt , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Christoph Hellwig , Ananth N Mavinakayanahalli , Jim Keniston , "Frank Ch . Eigler" , Li Zefan Subject: Re: [GIT PULL] tracing/kprobes: Syntax updates, introduce perf probe References: <1255386309-4992-1-git-send-email-fweisbec@gmail.com> <20091013061323.GE3215@elte.hu> <20091013062227.GA8051@elte.hu> In-Reply-To: <20091013062227.GA8051@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2003 Lines: 63 Ingo Molnar wrote: > > * Ingo Molnar wrote: > >>> tools/perf/Makefile | 10 + >>> tools/perf/builtin-probe.c | 386 +++++++++++++++++++ >>> tools/perf/builtin.h | 1 + >>> tools/perf/perf.c | 1 + >>> tools/perf/util/probe-finder.c | 690 +++++++++++++++++++++++++++++++++++ >>> tools/perf/util/probe-finder.h | 70 ++++ >>> 8 files changed, 1271 insertions(+), 74 deletions(-) >>> create mode 100644 tools/perf/builtin-probe.c >>> create mode 100644 tools/perf/util/probe-finder.c >>> create mode 100644 tools/perf/util/probe-finder.h >> >> Hm, there's no x86 decoder change here - does this lot fixes the >> instruction decoder bug i reported some time ago? That is which keeps >> tracing/kprobes out of tip:master. > > See my previous report below. > > Ingo > > ----- Forwarded message from Ingo Molnar ----- > > Date: Sat, 3 Oct 2009 12:49:23 +0200 > From: Ingo Molnar > To: Frederic Weisbecker > Subject: Re: [GIT PULL] tracing/kprobes: kprobes fixes > Cc: LKML , > Steven Rostedt , > Li Zefan > > > ok, -tip testing found this new failure: > > TEST posttest > Error: ffffffff8106ac00: 66 0f 73 fd 04 pslldq $0x4,%xmm5 > Error: objdump says 5 bytes, but insn_get_length() says 4 (attr:8000) > make[1]: *** [posttest] Error 2 > make: *** [bzImage] Error 2 > > Ingo > Hmm, thank you for reporting, I've missed some group opcode... Thank you again, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/