Message-ID: <4AD48D8B.10609@suse.com>
Date: Tue, 13 Oct 2009 10:24:11 -0400
From: Jeff Mahoney <jeffm@suse.com>
Organization: SUSE Labs, Novell, Inc
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090915 SUSE/3.0b4-1.1 Thunderbird/3.0b4
MIME-Version: 1.0
To: Jonathan Cameron <Jonathan.Cameron@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: Complete sched.h removal from interrupt.h
References: <4AD39B4A.6030305@suse.com> <4AD45F94.8060806@gmail.com>
In-Reply-To: <4AD45F94.8060806@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1278
Lines: 39

On 10/13/2009 07:08 AM, Jonathan Cameron wrote:
> Hi Jeff,
>>  drivers/staging/iio/industrialio-core.c    |    2 ++
>>   
> ...
>> --- a/drivers/staging/iio/industrialio-core.c
>> +++ b/drivers/staging/iio/industrialio-core.c
>> @@ -19,6 +19,8 @@
>>  #include <linux/interrupt.h>
>>  #include <linux/poll.h>
>>  #include <linux/cdev.h>
>> +#include <linux/sched.h>
>> +#include <linux/wait.h>
>>  #include "iio.h"
>>  #include "trigger_consumer.h"
>>   
> Greg has already picked up a patch for this one, but might make more
> sense to drop
> that and merge all these fixes as one.  Original patch only added
> sched.h though.
> Is wait.h due to a similar issue that is going to bite in the future?
> (could chase this
> down but as you added it seemed easier to ask!)

Nope, I think iio was probably the first driver I saw this build failure
in and observed that it was in the wait queue code. It's not necessary,
though it doesn't cost anything either since wait.h is already included
somewhere.

-Jeff

-- 
Jeff Mahoney
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/