Subject: Re: [PATCH] sysfs: mark a locally-only used function static
From: "David P. Quigley" <dpquigl@tycho.nsa.gov>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: James Morris <jmorris@namei.org>, "Stephen D. Smalley" <sds@tycho.nsa.gov>,
       linux-kernel@vger.kernel.org, greg@kroah.com
In-Reply-To: <tkrat.974f8a5e166a4c9f@s5r6.in-berlin.de>
References: <tkrat.974f8a5e166a4c9f@s5r6.in-berlin.de>
Content-Type: text/plain
Organization: National Security Agency
Date: Tue, 13 Oct 2009 10:42:44 -0400
Message-Id: <1255444964.11749.340.camel@moss-terrapins.epoch.ncsc.mil>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1215
Lines: 38

On Sun, 2009-10-11 at 03:02 +0200, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
> diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
> index e28cecf..e144351 100644
> --- a/fs/sysfs/inode.c
> +++ b/fs/sysfs/inode.c
> @@ -46,7 +46,7 @@ int __init sysfs_inode_init(void)
>  	return bdi_init(&sysfs_backing_dev_info);
>  }
>  
> -struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
> +static struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
>  {
>  	struct sysfs_inode_attrs *attrs;
>  	struct iattr *iattrs;
> @@ -64,6 +64,7 @@ struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
>  
>  	return attrs;
>  }
> +
>  int sysfs_setattr(struct dentry * dentry, struct iattr * iattr)
>  {
>  	struct inode * inode = dentry->d_inode;
> 

I don't see why this shouldn't or can't be made static. I'll ACK it and
then you guys can deal with it however you like.

-Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/