Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759931AbZJMOs5 (ORCPT ); Tue, 13 Oct 2009 10:48:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753756AbZJMOs4 (ORCPT ); Tue, 13 Oct 2009 10:48:56 -0400 Received: from hera.kernel.org ([140.211.167.34]:52166 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753468AbZJMOsz (ORCPT ); Tue, 13 Oct 2009 10:48:55 -0400 Message-ID: <4AD49317.6080503@kernel.org> Date: Tue, 13 Oct 2009 23:47:51 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Christoph Lameter CC: Stephen Rothwell , Rusty Russell , Ingo Molnar , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] this_cpu: Use this_cpu_xx in trace_functions_graph.c References: <20091013144812.bdb376aa.sfr@canb.auug.org.au> <4AD48EC4.8040701@kernel.org> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Tue, 13 Oct 2009 14:48:07 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 836 Lines: 25 Christoph Lameter wrote: > On Tue, 13 Oct 2009, Tejun Heo wrote: > >> ftrace_cpu_disabled usage in trace_functions_graph.c were left out >> during this_cpu_xx conversion in commit 9288f99a causing compile >> failure. Convert them. > > Thanks. > > Reviewed-by: Christoph Lameter Oh... one question tho. I used __this_cpu_*() as other conversions but I think we should be using the version without the underscores. The relationship between get_cpu_var() and __get_cpu_var() is different from the one between this_cpu_*() and __this_cpu_*(). Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/