Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760186AbZJMPLb (ORCPT ); Tue, 13 Oct 2009 11:11:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750901AbZJMPLa (ORCPT ); Tue, 13 Oct 2009 11:11:30 -0400 Received: from qw-out-2122.google.com ([74.125.92.24]:37979 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760141AbZJMPL3 convert rfc822-to-8bit (ORCPT ); Tue, 13 Oct 2009 11:11:29 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=aLHTms30SFs7O3ZziUECbr8yX8Qbb9zM9ppjaX/R3DTGvYUCihhT5gcKoSR8K2wzmb PwtOQ7Yt+Enzl9Qv6pEljWoEe1SUi5kc/qpqX0N0gdo01oi/1YbeP/7VEmG6XAPZsdjR 06agQTMPMRKXhg7G0ulUUv6B1mGw+kxnnRI7Y= MIME-Version: 1.0 In-Reply-To: <4AD2EBC6.1000505@msgid.tls.msk.ru> References: <20091011221818.GA2833@merkur.ravnborg.org> <4AD2EBC6.1000505@msgid.tls.msk.ru> Date: Tue, 13 Oct 2009 23:10:19 +0800 Message-ID: <2375c9f90910130810w2d887dd2uea0f4bc88ac2d894@mail.gmail.com> Subject: Re: [GIT PULL] kbuild fixes From: =?UTF-8?Q?Am=C3=A9rico_Wang?= To: Michael Tokarev Cc: Sam Ravnborg , Linus Torvalds , lkml , linux-kbuild Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1083 Lines: 36 On Mon, Oct 12, 2009 at 4:41 PM, Michael Tokarev wrote: > Sam Ravnborg wrote: >> >> Hi Linus. >> >> A few kbuild related fixes. > > [] >> >> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users > > As has been discussed previously (and Sam has been CC'ed), the fix > is still incorrect.  It replaces "echo -ne" with "/bin/echo -ne", > but neither of the two are guaranteed to support the necessary > arguments and necessary (hexadecimal) escape sequences.  What should > be used here is printf(1).  The trivial patch below (on top of these > kbuild changes) fixes this issue. > > Thanks. > > /mjt > > Signed-Off-By: Michael Tokarev > Sorry, I just saw this email. Hmm, printf(1) should be more portable than echo(1), I checked your patch, how about using 'printf "%b" ' instead? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/