Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760345AbZJMPm4 (ORCPT ); Tue, 13 Oct 2009 11:42:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760296AbZJMPmz (ORCPT ); Tue, 13 Oct 2009 11:42:55 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49269 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760290AbZJMPmy (ORCPT ); Tue, 13 Oct 2009 11:42:54 -0400 Date: Tue, 13 Oct 2009 08:41:23 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Paul Fulghum cc: Alan Cox , Nix , "Justin P. Mattock" , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Boyan , Dmitry Torokhov , Ed Tomlinson , =?ISO-8859-15?Q?Fr=E9d=E9ric_L=2E_W=2E_Meunier?= , OGAWA Hirofumi Subject: Re: [Bug #14388] keyboard under X with 2.6.31 In-Reply-To: <1255447980.3898.3.camel@x2.microgate.com> Message-ID: References: <56acieJJ2fF.A.nEB.Hzl0KB@chimera> <87ljjgfcbu.fsf@spindle.srvr.nix> <20091013113232.384b2432@lxorguk.ukuu.org.uk> <1255447980.3898.3.camel@x2.microgate.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1695 Lines: 40 On Tue, 13 Oct 2009, Paul Fulghum wrote: > On Tue, 2009-10-13 at 07:39 -0700, Linus Torvalds wrote: > > It's not a f*cking performance tweak, and you're ludicrous to claim it is. > > It's pointless, and it's making the code _slower_ rather than faster. > > > > Lookie here, Alan - the common sequence is crap like this: > > > > tty_buffer_request_room(tty, buf->size); > > tty_insert_flip_string(tty, buf->base, buf->size); > > The performance tweak of tty_prepare_xxx is that you fill > the tty_buffer directly instead of writing data first to a staging > buffer and then calling tty_insert_flip_string, which just copies > from the staging buffer to the tty_buffer. So it saves a copy operation. Read the above again. Read what that common sequence is. Please just READ the f*cking code, and read my emails, instead of talking about something totally different that I'm not talking about at all. The _most_common_ use of "tty_buffer_request_room()" is literally just the above insane sequence I quoted, not the case you talk about at all. Don't believe me? Use grep. What _you_ are talking about is something else, namely the tty_prepare_flip stuff. But dammit, that has nothing what-so-ever to do with "tty_buffer_request_room()". What I was pointing out is that there are a lot of "tty_buffer_request_room()" calls, and as far as I can see, all of them (or at least a large percentage) are just pure and utter crap. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/