Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760442AbZJMPom (ORCPT ); Tue, 13 Oct 2009 11:44:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760409AbZJMPoe (ORCPT ); Tue, 13 Oct 2009 11:44:34 -0400 Received: from one.firstfloor.org ([213.235.205.2]:35936 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760388AbZJMPod (ORCPT ); Tue, 13 Oct 2009 11:44:33 -0400 Date: Tue, 13 Oct 2009 17:43:56 +0200 From: Andi Kleen To: Hugh Dickins Cc: Andi Kleen , Wu Fengguang , Izik Eidus , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwpoison: fix oops on ksm pages Message-ID: <20091013154356.GA2127@basil.fritz.box> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 18 On Tue, Oct 13, 2009 at 03:02:11PM +0100, Hugh Dickins wrote: > Memory failure on a KSM page currently oopses on its NULL anon_vma in > page_lock_anon_vma(): that may not be much worse than the consequence > of ignoring it, but it is better to be consistent with how ZERO_PAGE > and hugetlb pages and other awkward cases are treated. Just skip it. Thanks, Hugh. I'm curious: did this come out of code review or did you actually run into that? -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/