Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761313AbZJMVDJ (ORCPT ); Tue, 13 Oct 2009 17:03:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760815AbZJMVDI (ORCPT ); Tue, 13 Oct 2009 17:03:08 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59642 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbZJMVDG (ORCPT ); Tue, 13 Oct 2009 17:03:06 -0400 Date: Tue, 13 Oct 2009 14:02:03 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Boyan cc: =?ISO-8859-15?Q?Fr=E9d=E9ric_L=2E_W=2E_Meunier?= , "Justin P. Mattock" , Nix , Alan Cox , Paul Fulghum , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Dmitry Torokhov , Ed Tomlinson , OGAWA Hirofumi Subject: Re: [Bug #14388] keyboard under X with 2.6.31 In-Reply-To: Message-ID: References: <56acieJJ2fF.A.nEB.Hzl0KB@chimera> <87ljjgfcbu.fsf@spindle.srvr.nix> <4AD3F769.5080405@gmail.com> <4AD437F9.9020708@yahoo.co.uk> <4AD4DE4C.4010402@yahoo.co.uk> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 29 On Tue, 13 Oct 2009, Linus Torvalds wrote: > > Anyway, I'm not entirely happy with this patch, and I haven't actually > TESTED it so it might well be totally broken [..] It is. Looking over the patch a bit more, at a minimum that if (test_and_set_bit(TTY_FLUSHING, &tty->flags)) { line should be if (!test_and_set_bit(TTY_FLUSHING, &tty->flags)) { (ie add the '!') since we want to do things if the bit wasn't set before (and if it was already set it all turns into a no-op). But apart from that obvious typo, the patch still looks good even after looking it through a bit more. It's still TOTALLY UNTESTED, though! Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/