Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761497AbZJMWCM (ORCPT ); Tue, 13 Oct 2009 18:02:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761027AbZJMWCL (ORCPT ); Tue, 13 Oct 2009 18:02:11 -0400 Received: from sous-sol.org ([216.99.217.87]:42624 "EHLO sequoia.sous-sol.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753593AbZJMWCJ (ORCPT ); Tue, 13 Oct 2009 18:02:09 -0400 Date: Tue, 13 Oct 2009 15:00:13 -0700 From: Chris Wright To: Alok Kataria Cc: Chris Wright , James Bottomley , Randy Dunlap , Mike Christie , Bart Van Assche , "linux-scsi@vger.kernel.org" , Matthew Wilcox , "pv-drivers@vmware.com" , Roland Dreier , LKML , "Chetan.Loke@Emulex.Com" , Brian King , Rolf Eike Beer , Robert Love , Andrew Morton , Daniel Walker , Greg KH , "virtualization@lists.linux-foundataion.org" Subject: Re: SCSI driver for VMware's virtual HBA - V5. Message-ID: <20091013220013.GB2908@sequoia.sous-sol.org> References: <1254336812.19921.23.camel@ank32.eng.vmware.com> <20091002004725.GP3958@sequoia.sous-sol.org> <1254789028.15233.54.camel@ank32.eng.vmware.com> <20091013053726.GE17547@sequoia.sous-sol.org> <1255469294.12792.93.camel@ank32.eng.vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1255469294.12792.93.camel@ank32.eng.vmware.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 24 * Alok Kataria (akataria@vmware.com) wrote: > On Mon, 2009-10-12 at 22:37 -0700, Chris Wright wrote: > > > + pvscsi_template.can_queue = > > > + min(PVSCSI_MAX_NUM_PAGES_REQ_RING, pvscsi_ring_pages) * > > > + PVSCSI_MAX_NUM_REQ_ENTRIES_PER_PAGE; > > > + pvscsi_template.cmd_per_lun = > > > + min(pvscsi_template.can_queue, pvscsi_cmd_per_lun); > > > > When/how are these tunables used? Are they still useful? > > cmd_per_lun, is a commandline parameter. Actually I meant how is a user supposed to use these? They looked to me like tunables that were part of developing a driver that may not be needed any longer. What are the right values, what are the tradeoffs, etc? Or should they just be removed? thanks, -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/