Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761607AbZJMXch (ORCPT ); Tue, 13 Oct 2009 19:32:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757454AbZJMXch (ORCPT ); Tue, 13 Oct 2009 19:32:37 -0400 Received: from gate.crashing.org ([63.228.1.57]:51921 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbZJMXcg (ORCPT ); Tue, 13 Oct 2009 19:32:36 -0400 Subject: Re: USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH] From: Benjamin Herrenschmidt To: Alan Stern Cc: Ben Efros , Josua Dietze , fangxiaozhi , Greg KH , Kernel development list , USB list , Hugh Blemings In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Wed, 14 Oct 2009 10:30:06 +1100 Message-Id: <1255476606.2347.15.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 31 On Tue, 2009-10-13 at 10:03 -0400, Alan Stern wrote: > On Tue, 13 Oct 2009, Benjamin Herrenschmidt wrote: > > > usb-storage: Workaround devices with bogus sense size > > > > Some devices, such as Huawei E169, advertise more than the standard > > amount of sense data, causing us to set US_FL_SANE_SENSE, assuming > > they support it. However, they subsequently fail the request sense > > with that size. > > > > This works around it generically. When a sense request fails due to > > a device returning an error, US_FL_SANE_SENSE was set, and that sense > > request used a larger sense size, we retry with a smaller size before > > giving up. > > > > Based on an original patch by Ben Efros > > > > Signed-off-by: Benjamin Herrenschmidt > > Acked-by: Alan Stern Cool. Who's going to commit it ? Greg ? Or should I send it to Linus ? Cheers, Ben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/