Message-ID: <4AD51519.8030902@windriver.com>
Date: Tue, 13 Oct 2009 19:02:33 -0500
From: Jason Wessel <jason.wessel@windriver.com>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: Bernhard Walle <bernhard@bwalle.de>
CC: Jesse Barnes <jbarnes@virtuousgeek.org>, Andi Kleen <andi@firstfloor.org>,
       akpm@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Always print panic message on current console
References: <1255207870-24496-1-git-send-email-bernhard@bwalle.de>	<1255207870-24496-6-git-send-email-bernhard@bwalle.de>	<87d44sh5uj.fsf@basil.nowhere.org>	<4AD37478.2070204@bwalle.de> <20091012113055.13d3b7e3@jbarnes-g45> <4AD376B9.7040404@bwalle.de>
In-Reply-To: <4AD376B9.7040404@bwalle.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1517
Lines: 36

Bernhard Walle wrote:
> Jesse Barnes schrieb:
>   
>> It's called in the panic notifier atm.  Yeah sounds like kexec vs
>> notifiers should be reordered a bit (or the current panic notifier
>> should be split into notify and "yes we actually failed to do anything"
>> cases).
>>     
>
> Well, we had that discussion several times. But maybe the opinion of
> some developers changed because now there would be an in-kernel user of
> notification before kexec.
>   

The other internal kernel user would be kdb (granted it is not merged to
the mainline at this point).  The prototype that we demonstrated at LPC
hooked the panic notification first and passed the string that was
passed to the panic.

Where KMS is integrated with KDB all the switching is dynamic and you do
get a chance to see what happened as well as interact with the
debugger.  The argument of folks who only care about kexec has always
been they want the first right of anything to get to kexec before
anything could get worse by going down any other code paths.

The kms does not have the choice to dynamically configure the behavior
on panic, where as kdb/kgdb is something you activate if you plan on
debugging (meaning user preference is clear).  Perhaps two notifiers is
the right answer.

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/