Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbZJNEuV (ORCPT ); Wed, 14 Oct 2009 00:50:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752489AbZJNEuU (ORCPT ); Wed, 14 Oct 2009 00:50:20 -0400 Received: from terminus.zytor.com ([198.137.202.10]:41830 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752246AbZJNEuT (ORCPT ); Wed, 14 Oct 2009 00:50:19 -0400 Message-ID: <4AD555E2.4090904@zytor.com> Date: Tue, 13 Oct 2009 21:38:58 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Sukadev Bhattiprolu CC: Roland McGrath , linux-kernel@vger.kernel.org, Oren Laadan , serue@us.ibm.com, "Eric W. Biederman" , Alexey Dobriyan , Pavel Emelyanov , Andrew Morton , torvalds@linux-foundation.org, mikew@google.com, mingo@elte.hu, Nathan Lynch , arnd@arndb.de, peterz@infradead.org, Louis.Rilling@kerlabs.com, kosaki.motohiro@jp.fujitsu.com, randy.dunlap@oracle.com, linux-api@vger.kernel.org, Containers , sukadev@us.ibm.com Subject: Re: [RFC][v8][PATCH 0/10] Implement clone3() system call References: <20091013044925.GA28181@us.ibm.com> <20091013205015.1ED524F7@magilla.sf.frob.com> <20091013232736.GA24392@us.ibm.com> <20091013235320.E90022746@magilla.sf.frob.com> <4AD525B3.2070906@zytor.com> <20091014043607.GA32114@us.ibm.com> In-Reply-To: <20091014043607.GA32114@us.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 698 Lines: 21 On 10/13/2009 09:36 PM, Sukadev Bhattiprolu wrote: > > Would it help to use a type clone_flags_64_t to make the distinction > between types more explicit ? > The problem with using the same flags in two places, one as a 32-bit and one as a 64-bit number, is that using one in the wrong place will cause silent, but deadly, truncation. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/