Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757230AbZJNHoJ (ORCPT ); Wed, 14 Oct 2009 03:44:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756522AbZJNHoJ (ORCPT ); Wed, 14 Oct 2009 03:44:09 -0400 Received: from smtp-out.google.com ([216.239.33.17]:46356 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755785AbZJNHoI (ORCPT ); Wed, 14 Oct 2009 03:44:08 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=jeUHQjw5hQyGvpd/K0U6pXuqrE0rxHE1Dy8vdEVONf8G3JHf0F9ZvWTPzGq47o3nX 2dGLctGYmnVAptSmvo8Aw== Date: Wed, 14 Oct 2009 00:42:44 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Ingo Molnar cc: Linus Torvalds , Frans Pop , Dirk Hohndel , Len Brown , Linux Kernel Mailing List Subject: Re: [PATCH, v2] kbuild: Improve version string logic In-Reply-To: <20091014073306.GB22778@elte.hu> Message-ID: References: <200910130004.46388.elendil@planet.nl> <20091013070505.GC31483@elte.hu> <200910131952.01209.elendil@planet.nl> <20091014065941.GH784@elte.hu> <20091014073306.GB22778@elte.hu> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1592 Lines: 35 On Wed, 14 Oct 2009, Ingo Molnar wrote: > > Regardless of future improvements, I think my two patches allow the > > kernel version to more accurately describe what is running. That is > > predicated on my belief that "v2.6.32-rc4", though, should never > > describe _anything_ except the kernel.org v2.6.32-rc4 kernel. > > I agree with all that - in fact i started this thread by stating that > view and suggesting the '+' extension to the short version name. > Yeah, my patches build upon the base that you originally proposed. I like the `+' suffix for configs with CONFIG_LOCALVERSION_AUTO that aren't vanilla kernels. > But there's been packaging related objections from Frans and others, and > i suspect you'll need to answer/address those instead of further > detailing the virtues of proper version names (which i still 100% agree > with). > We could easily go with my suggestion of allowing "make LOCALVERSION=" to override all additions to the kernel version when CONFIG_LOCALVERSION_AUTO is disabled. For such configurations, kernels would be built with this variable to specify how it's different from the vanilla version and would suppress the `+'. Frans and others, how does adding a unique string passed by the user for a more descriptive kernel version interact poorly with certain packaging requirements? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/