Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758169AbZJNJD1 (ORCPT ); Wed, 14 Oct 2009 05:03:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755672AbZJNJD0 (ORCPT ); Wed, 14 Oct 2009 05:03:26 -0400 Received: from mtagate1.de.ibm.com ([195.212.17.161]:45262 "EHLO mtagate1.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755427AbZJNJDZ (ORCPT ); Wed, 14 Oct 2009 05:03:25 -0400 Date: Wed, 14 Oct 2009 11:02:46 +0200 From: Martin Schwidefsky To: Kamalesh Babulal Cc: Peter.Oberparleiter@de.ibm.com, linux-next@vger.kernel.org, LKML , Stephen Rothwell , heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org Subject: Re: [BUILD_FAILURE] next-20091013 s390x - build breaks SCLP VT220 terminal driver Message-ID: <20091014110246.3c76f93f@mschwide.boeblingen.de.ibm.com> In-Reply-To: <20091013162809.GA27977@linux.vnet.ibm.com> References: <20091013162312.8b93998b.sfr@canb.auug.org.au> <20091013162809.GA27977@linux.vnet.ibm.com> Organization: IBM Corporation X-Mailer: Claws Mail 3.7.3 (GTK+ 2.18.2; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2027 Lines: 63 On Tue, 13 Oct 2009 21:58:09 +0530 Kamalesh Babulal wrote: > next-20091013 randconfig build on s390x build breaks with > > drivers/s390/built-in.o:(.data+0x3354): undefined reference to `sclp_vt220_pm_event_fn' This patch should take care of it: -- Subject: [PATCH] sclp_vt220 build fix From: Martin Schwidefsky Fix this build error: next-20091013 randconfig build on s390x build breaks with drivers/s390/built-in.o:(.data+0x3354): undefined reference to `sclp_vt220_pm_event_fn' Reported-by: Kamalesh Babulal Signed-off-by: Martin Schwidefsky --- drivers/s390/char/sclp_vt220.c | 4 ++++ 1 file changed, 4 insertions(+) diff -urpN linux-2.6/drivers/s390/char/sclp_vt220.c linux-2.6-patched/drivers/s390/char/sclp_vt220.c --- linux-2.6/drivers/s390/char/sclp_vt220.c 2009-09-10 00:13:59.000000000 +0200 +++ linux-2.6-patched/drivers/s390/char/sclp_vt220.c 2009-10-14 11:00:22.000000000 +0200 @@ -93,8 +93,10 @@ static int __initdata sclp_vt220_init_co static int sclp_vt220_flush_later; static void sclp_vt220_receiver_fn(struct evbuf_header *evbuf); +#ifdef CONFIG_SCLP_VT220_CONSOLE static void sclp_vt220_pm_event_fn(struct sclp_register *reg, enum sclp_pm_event sclp_pm_event); +#endif static int __sclp_vt220_emit(struct sclp_vt220_request *request); static void sclp_vt220_emit_current(void); @@ -104,7 +106,9 @@ static struct sclp_register sclp_vt220_r .receive_mask = EVTYP_VT220MSG_MASK, .state_change_fn = NULL, .receiver_fn = sclp_vt220_receiver_fn, +#ifdef CONFIG_SCLP_VT220_CONSOLE .pm_event_fn = sclp_vt220_pm_event_fn, +#endif }; -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/