Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934772AbZJNPw3 (ORCPT ); Wed, 14 Oct 2009 11:52:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934738AbZJNPw1 (ORCPT ); Wed, 14 Oct 2009 11:52:27 -0400 Received: from hera.kernel.org ([140.211.167.34]:34697 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934713AbZJNPw0 (ORCPT ); Wed, 14 Oct 2009 11:52:26 -0400 Date: Wed, 14 Oct 2009 15:51:30 GMT From: tip-bot for Thomas Gleixner Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com, rdreier@cisco.com, tglx@linutronix.de Reply-To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, rdreier@cisco.com, tglx@linutronix.de In-Reply-To: References: To: linux-tip-commits@vger.kernel.org Subject: [tip:bkl/drivers] inifiband: Remove BKL from ipath_open() Message-ID: Git-Commit-ID: f96d3015e9f7f7fff4cab7ed1d467664cc980061 X-Mailer: tip-git-log-daemon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Wed, 14 Oct 2009 15:51:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1771 Lines: 41 Commit-ID: f96d3015e9f7f7fff4cab7ed1d467664cc980061 Gitweb: http://git.kernel.org/tip/f96d3015e9f7f7fff4cab7ed1d467664cc980061 Author: Thomas Gleixner AuthorDate: Wed, 14 Oct 2009 16:36:26 +0200 Committer: Thomas Gleixner CommitDate: Wed, 14 Oct 2009 17:36:54 +0200 inifiband: Remove BKL from ipath_open() cycle_kernel_lock() got pushed down to ipath_open(). I tried hard to understand what it might protect, but finally gave up. Roland noted that qlogic seems to have abandoned the ipath driver and came to the following wise conclusion: "So I guess if the BKL stuff is blocking you in any way, we can just drop it from ipath and leave it as yet another race condition in a rotting old driver." Signed-off-by: Thomas Gleixner LKML-Reference: Cc: Roland Dreier --- drivers/infiniband/hw/ipath/ipath_file_ops.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ipath/ipath_file_ops.c b/drivers/infiniband/hw/ipath/ipath_file_ops.c index 40dbe54..73933a4 100644 --- a/drivers/infiniband/hw/ipath/ipath_file_ops.c +++ b/drivers/infiniband/hw/ipath/ipath_file_ops.c @@ -1821,7 +1821,6 @@ done: static int ipath_open(struct inode *in, struct file *fp) { /* The real work is performed later in ipath_assign_port() */ - cycle_kernel_lock(); fp->private_data = kzalloc(sizeof(struct ipath_filedata), GFP_KERNEL); return fp->private_data ? 0 : -ENOMEM; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/