Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934825AbZJNQDL (ORCPT ); Wed, 14 Oct 2009 12:03:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761944AbZJNQDK (ORCPT ); Wed, 14 Oct 2009 12:03:10 -0400 Received: from e28smtp05.in.ibm.com ([59.145.155.5]:46079 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754890AbZJNQDG (ORCPT ); Wed, 14 Oct 2009 12:03:06 -0400 Date: Wed, 14 Oct 2009 21:32:26 +0530 From: Kamalesh Babulal To: Martin Schwidefsky Cc: Peter.Oberparleiter@de.ibm.com, linux-next@vger.kernel.org, LKML , Stephen Rothwell , heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org Subject: Re: [BUILD_FAILURE] next-20091013 s390x - build breaks SCLP VT220 terminal driver Message-ID: <20091014160226.GA5324@linux.vnet.ibm.com> Reply-To: Kamalesh Babulal References: <20091013162312.8b93998b.sfr@canb.auug.org.au> <20091013162809.GA27977@linux.vnet.ibm.com> <20091014124553.596e7f5a@mschwide.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20091014124553.596e7f5a@mschwide.boeblingen.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2907 Lines: 95 * Martin Schwidefsky [2009-10-14 12:45:53]: > On Tue, 13 Oct 2009 21:58:09 +0530 > Kamalesh Babulal wrote: > > > next-20091013 randconfig build on s390x build breaks with > > > > drivers/s390/built-in.o:(.data+0x3354): undefined reference to `sclp_vt220_pm_event_fn' > > Michael pointed out a problem with my fix: suspend/resume of a vt220 console with > SCLP_VT220_CONSOLE=n doesn't work any more. V2 of the patch: > Thanks, the patch fixes the build failure. > -- > Subject: [PATCH] sclp_vt220 build fix > > From: Michael Holzheu > > Fix this build error: > > next-20091013 randconfig build on s390x build breaks with > > drivers/s390/built-in.o:(.data+0x3354): undefined reference to `sclp_vt220_pm_event_fn' > Tested-by: Kamalesh Babulal > Reported-by: Kamalesh Babulal > Signed-off-by: Michael Holzheu > Signed-off-by: Martin Schwidefsky > --- > > drivers/s390/char/sclp_vt220.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff -urpN linux-2.6/drivers/s390/char/sclp_vt220.c linux-2.6-patched/drivers/s390/char/sclp_vt220.c > --- linux-2.6/drivers/s390/char/sclp_vt220.c 2009-09-10 00:13:59.000000000 +0200 > +++ linux-2.6-patched/drivers/s390/char/sclp_vt220.c 2009-10-14 12:41:48.000000000 +0200 > @@ -705,21 +705,6 @@ out_driver: > } > __initcall(sclp_vt220_tty_init); > > -#ifdef CONFIG_SCLP_VT220_CONSOLE > - > -static void > -sclp_vt220_con_write(struct console *con, const char *buf, unsigned int count) > -{ > - __sclp_vt220_write((const unsigned char *) buf, count, 1, 1, 0); > -} > - > -static struct tty_driver * > -sclp_vt220_con_device(struct console *c, int *index) > -{ > - *index = 0; > - return sclp_vt220_driver; > -} > - > static void __sclp_vt220_flush_buffer(void) > { > unsigned long flags; > @@ -776,6 +761,21 @@ static void sclp_vt220_pm_event_fn(struc > } > } > > +#ifdef CONFIG_SCLP_VT220_CONSOLE > + > +static void > +sclp_vt220_con_write(struct console *con, const char *buf, unsigned int count) > +{ > + __sclp_vt220_write((const unsigned char *) buf, count, 1, 1, 0); > +} > + > +static struct tty_driver * > +sclp_vt220_con_device(struct console *c, int *index) > +{ > + *index = 0; > + return sclp_vt220_driver; > +} > + > static int > sclp_vt220_notify(struct notifier_block *self, > unsigned long event, void *data) > -- > blue skies, > Martin. > > "Reality continues to ruin my life." - Calvin. > Kamalesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/