Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761966AbZJNQIw (ORCPT ); Wed, 14 Oct 2009 12:08:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934423AbZJNQIv (ORCPT ); Wed, 14 Oct 2009 12:08:51 -0400 Received: from www.tglx.de ([62.245.132.106]:46107 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761957AbZJNQIu (ORCPT ); Wed, 14 Oct 2009 12:08:50 -0400 Date: Wed, 14 Oct 2009 18:07:55 +0200 (CEST) From: Thomas Gleixner To: Arnd Bergmann cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, gregkh@suse.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:bkl/drivers] drivers: Remove BKL from misc_open In-Reply-To: <200910141755.00774.arnd@arndb.de> Message-ID: References: <20091010153349.237173041@linutronix.de> <200910141755.00774.arnd@arndb.de> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1111 Lines: 30 On Wed, 14 Oct 2009, Arnd Bergmann wrote: > On Wednesday 14 October 2009, tip-bot for Thomas Gleixner wrote: > > Commit-ID: 40b798efe3460797a4ac928ee2e038774e2758eb > > Gitweb: http://git.kernel.org/tip/40b798efe3460797a4ac928ee2e038774e2758eb > > Author: Thomas Gleixner > > AuthorDate: Sat, 10 Oct 2009 15:35:43 +0000 > > Committer: Thomas Gleixner > > CommitDate: Wed, 14 Oct 2009 17:33:32 +0200 > > > > drivers: Remove BKL from misc_open > > > > misc_open() is already serialized with misc_mtx. Remove the BKL > > locking which got there via the BKL pushdown. > > Did you check the misc drivers to make sure this is not silently > removing the BKL from drivers that need it? Yep, they are plastered with cycle_kernel_lock and lock/unlock_kernel already. I might have missed some, but ... Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/