Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934541AbZJNPb1 (ORCPT ); Wed, 14 Oct 2009 11:31:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934526AbZJNPb0 (ORCPT ); Wed, 14 Oct 2009 11:31:26 -0400 Received: from adsl-70-250-156-241.dsl.austtx.swbell.net ([70.250.156.241]:54806 "EHLO gw.microgate.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934416AbZJNPbZ (ORCPT ); Wed, 14 Oct 2009 11:31:25 -0400 Message-ID: <4AD5FDAC.7080108@microgate.com> Date: Wed, 14 Oct 2009 10:34:52 -0600 From: Paul Fulghum User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Linus Torvalds CC: Alan Cox , Boyan , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Dmitry Torokhov , Ed Tomlinson , "" Subject: Re: [Bug #14388] keyboard under X with 2.6.31 References: <56acieJJ2fF.A.nEB.Hzl0KB@chimera> <87ljjgfcbu.fsf@spindle.srvr.nix> <4AD3F769.5080405@gmail.com> <4AD437F9.9020708@yahoo.co.uk> <4AD4DE4C.4010402@yahoo.co.uk> <4AD4F548.2030506@microgate.com> <1255478932.19056.24.camel@localhost.localdomain> <4AD51D6B.7010509@microgate.com> <20091014125846.1a3c8d40@lxorguk.ukuu.org.uk> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 31 Linus Torvalds wrote: > No, the code was clearly _designed_ for it - that's the whole and only > point of the > > tty->buf.head = NULL; I don't know about the original flush_to_ldisc, but I designed the above code to protect against parallel calls knowing I could not hold a spinlock when calling receive_buf. TTY_FLUSHING came later. The problem associated with that addition proves my code is obscure enough to make maintenance difficult. I got confused reviewing my own code yesterday. Boo hoo, live and learn. -- Paul Fulghum MicroGate Systems, Ltd. =Customer Driven, by Design= (800)444-1982 (512)345-7791 (Direct) (512)343-9046 (Fax) Central Time Zone (GMT -5h) www.microgate.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/