Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756818AbZJNSeo (ORCPT ); Wed, 14 Oct 2009 14:34:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756579AbZJNSen (ORCPT ); Wed, 14 Oct 2009 14:34:43 -0400 Received: from smtp2.ultrahosting.com ([74.213.174.253]:55459 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756576AbZJNSen (ORCPT ); Wed, 14 Oct 2009 14:34:43 -0400 Date: Wed, 14 Oct 2009 14:26:37 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: "H. Peter Anvin" cc: "Luck, Tony" , Tejun Heo , "linux-kernel@vger.kernel.org" , "rusty@rustcorp.com.au" , "mingo@redhat.com" , Thomas Gleixner , "akpm@linux-foundation.org" , "rostedt@goodmis.org" , "cebbert@redhat.com" Subject: Re: [PATCH 13/16] percpu: remove per_cpu__ prefix. In-Reply-To: <4AD60C78.1090908@zytor.com> Message-ID: References: <1255500125-3210-1-git-send-email-tj@kernel.org> <1255500125-3210-14-git-send-email-tj@kernel.org> <57C9024A16AD2D4C97DC78E552063EA3E32264A8@orsmsx505.amr.corp.intel.com> <4AD60C78.1090908@zytor.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 25 On Wed, 14 Oct 2009, H. Peter Anvin wrote: > Okay... I also don't seem to understand the more fundamental issue here, > which is: > > Why are we dropping the prefix? That has been answered by Tejun elsewhere. It simplifies macros in many places. Makes treatment of dynamic and static per cpu variables uniform, solves an issue on S/390 etc. > It may be "insufficient", but at least it stands out like a sore thumb > and makes mistakes harder. It would be a different thing if we could > actually use the TLS ABI, but we really can't. Sparse annotations will be used to detect these issues. Also generally per cpu variables are used as parameters to per cpu functions. They only work in the context of specifically designed macros. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/