Subject: Re: [PATCH 1/1] Added an additional Sony laptop to
 acpi_osi_dmi_table
From: Daniel Walker <dwalker@fifo99.com>
To: Tim Hoppen <timhoppen@gmail.com>
Cc: lenb@kernel.org, rui.zhang@intel.com, jgarzik@redhat.com, tj@kernel.org,
       linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <1255568391-8400-1-git-send-email-timhoppen@gmail.com>
References: <1255568391-8400-1-git-send-email-timhoppen@gmail.com>
Content-Type: text/plain
Date: Wed, 14 Oct 2009 18:48:49 -0700
Message-Id: <1255571329.22917.29.camel@desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1373
Lines: 36

On Wed, 2009-10-14 at 17:59 -0700, Tim Hoppen wrote:
> Signed-off-by: Tim Hoppen <timhoppen@gmail.com>
> ---
>  drivers/acpi/blacklist.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index e56b2a7..01cca5f 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -211,6 +211,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  		     DMI_MATCH(DMI_PRODUCT_NAME, "Sony VGN-SR290J"),
>  		},
>  	},
> +	{
> +        .callback = dmi_disable_osi_vista,
> +        .ident = "Sony VGN-FW351J",
> +        .matches = {
> +                     DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
> +                     DMI_MATCH(DMI_PRODUCT_NAME, "VGN-FW351J"),
> +                },
> +        },

It looks like your not indenting correctly. The above lines should be
tabbed instead of just spaced over .. You may have done copy and paste
on this block from the code around this. Copy and paste usually doesn't
properly copy the tabs .. Could you resubmit this with the tabbing added
back in?

Daniel 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/